Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(660)

Issue 1340123002: Revert of VectorICs: ia32 store ics need a virtual register. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of VectorICs: ia32 store ics need a virtual register. (patchset #3 id:40001 of https://codereview.chromium.org/1336313002/ ) Reason for revert: [Sheriff] Breaks GC stress on mac: http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/2536 Original issue's description: > VectorICs: ia32 store ics need a virtual register. > > Some pretty hacky code was used to carry out the tail-call > handler dispatch on ia32 vector stores due to a lack > of free registers. It really tanks performance. A better > approach is to use a virtual register on the isolate. > > BUG= > > Committed: https://crrev.com/b26e98f19b5e77df50cb4a259f099ee6afa335e3 > Cr-Commit-Position: refs/heads/master@{#30718} TBR=jkummerow@chromium.org,vogelheim@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/a7a34b068c88993456ba79f13002507adc3a9bfc Cr-Commit-Position: refs/heads/master@{#30719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -50 lines) Patch
M src/assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/code-stubs-ia32.cc View 8 chunks +14 lines, -24 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 3 chunks +4 lines, -8 lines 0 comments Download
M src/isolate.h View 2 chunks +0 lines, -6 lines 0 comments Download
M src/isolate.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/snapshot/serialize.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of VectorICs: ia32 store ics need a virtual register.
5 years, 3 months ago (2015-09-14 18:58:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340123002/1
5 years, 3 months ago (2015-09-14 18:58:41 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 18:58:56 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 18:59:12 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a7a34b068c88993456ba79f13002507adc3a9bfc
Cr-Commit-Position: refs/heads/master@{#30719}

Powered by Google App Engine
This is Rietveld 408576698