Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender_test.cc

Issue 1340113002: relnote: Fixes test and flag description (addressing comments in (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang_tidy_102038333
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_flags.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/congestion_control/tcp_cubic_sender_test.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender_test.cc b/net/quic/congestion_control/tcp_cubic_sender_test.cc
index a97ddb6ea37a6d470fe57f9d7d62046bf9d2a820..26041ae018a1ed52974ab6d816d25cc70e8c4d10 100644
--- a/net/quic/congestion_control/tcp_cubic_sender_test.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender_test.cc
@@ -11,10 +11,12 @@
#include "net/quic/congestion_control/rtt_stats.h"
#include "net/quic/crypto/crypto_protocol.h"
#include "net/quic/proto/cached_network_parameters.pb.h"
+#include "net/quic/quic_flags.h"
#include "net/quic/quic_protocol.h"
#include "net/quic/quic_utils.h"
#include "net/quic/test_tools/mock_clock.h"
#include "net/quic/test_tools/quic_config_peer.h"
+#include "net/quic/test_tools/quic_test_utils.h"
#include "testing/gtest/include/gtest/gtest.h"
using std::min;
@@ -486,6 +488,7 @@ TEST_F(TcpCubicSenderTest, TcpCubicMaxCongestionWindow) {
}
TEST_F(TcpCubicSenderTest, TcpCubicResetEpochOnQuiescence) {
+ ValueRestore<bool> old_flag(&FLAGS_reset_cubic_epoch_when_app_limited, true);
const int kMaxCongestionWindow = 50;
const QuicByteCount kMaxCongestionWindowBytes =
kMaxCongestionWindow * kDefaultTCPMSS;
« no previous file with comments | « no previous file | net/quic/quic_flags.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698