Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Unified Diff: runtime/observatory/lib/src/elements/script_inset.dart

Issue 1340073002: Fix static analysis warnings in Observatory (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/elements/script_inset.dart
diff --git a/runtime/observatory/lib/src/elements/script_inset.dart b/runtime/observatory/lib/src/elements/script_inset.dart
index 2269c12bf9a03851c3f54a5419bc0b6f6a652512..958c777fbf2eaea13c0cebba4880a07bbd450a16 100644
--- a/runtime/observatory/lib/src/elements/script_inset.dart
+++ b/runtime/observatory/lib/src/elements/script_inset.dart
@@ -126,11 +126,8 @@ class BreakpointAnnotation extends Annotation {
line = script.tokenToLine(pos);
columnStart = script.tokenToCol(pos) - 1; // tokenToCol is 1-origin.
} else {
- line = bpt.location.line;
- columnStart = bpt.location.column;
- if (columnStart == null) {
- columnStart = 0;
- }
turnidge 2015/09/15 16:01:03 bpt.location can have two types: SourceLocation an
Cutch 2015/09/15 17:29:57 Yep, you are right. I've fixed the static warnings
+ line = 0;
+ columnStart = 0;
}
var length = script.guessTokenLength(line, columnStart);
if (length == null) {
@@ -1019,4 +1016,3 @@ class SourceInsetElement extends PolymerElement {
@published bool inDebuggerContext = false;
@published ObservableList variables;
}
-
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698