Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: runtime/observatory/lib/src/elements/debugger.dart

Issue 1340073002: Fix static analysis warnings in Observatory (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library debugger_page_element; 5 library debugger_page_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'dart:html'; 8 import 'dart:html';
9 import 'observatory_element.dart'; 9 import 'observatory_element.dart';
10 import 'package:observatory/app.dart'; 10 import 'package:observatory/app.dart';
(...skipping 1637 matching lines...) Expand 10 before | Expand all | Expand 10 after
1648 } else { 1648 } else {
1649 console.print('The program is already running'); 1649 console.print('The program is already running');
1650 } 1650 }
1651 } 1651 }
1652 1652
1653 Future syncNext() async { 1653 Future syncNext() async {
1654 if (isolatePaused()) { 1654 if (isolatePaused()) {
1655 var event = isolate.pauseEvent; 1655 var event = isolate.pauseEvent;
1656 if (event.kind == ServiceEvent.kPauseStart) { 1656 if (event.kind == ServiceEvent.kPauseStart) {
1657 console.print("Type 'continue' [F7] or 'step' [F10] to start the isolate "); 1657 console.print("Type 'continue' [F7] or 'step' [F10] to start the isolate ");
1658 return; 1658 return null;
1659 } 1659 }
1660 if (event.kind == ServiceEvent.kPauseExit) { 1660 if (event.kind == ServiceEvent.kPauseExit) {
1661 console.print("Type 'continue' [F7] to exit the isolate"); 1661 console.print("Type 'continue' [F7] to exit the isolate");
1662 return; 1662 return null;
1663 } 1663 }
1664 return isolate.stepOver(); 1664 return isolate.stepOver();
1665 } else { 1665 } else {
1666 console.print('The program is already running'); 1666 console.print('The program is already running');
1667 return; 1667 return null;
1668 } 1668 }
1669 } 1669 }
1670 1670
1671 Future step() { 1671 Future step() {
1672 if (isolatePaused()) { 1672 if (isolatePaused()) {
1673 var event = isolate.pauseEvent; 1673 var event = isolate.pauseEvent;
1674 if (event.kind == ServiceEvent.kPauseExit) { 1674 if (event.kind == ServiceEvent.kPauseExit) {
1675 console.print("Type 'continue' [F7] to exit the isolate"); 1675 console.print("Type 'continue' [F7] to exit the isolate");
1676 return new Future.value(null); 1676 return new Future.value(null);
1677 } 1677 }
(...skipping 678 matching lines...) Expand 10 before | Expand all | Expand 10 after
2356 } 2356 }
2357 }); 2357 });
2358 } 2358 }
2359 2359
2360 void focus() { 2360 void focus() {
2361 $['textBox'].focus(); 2361 $['textBox'].focus();
2362 } 2362 }
2363 2363
2364 DebuggerInputElement.created() : super.created(); 2364 DebuggerInputElement.created() : super.created();
2365 } 2365 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698