Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: base/base.isolate

Issue 134003004: Make net_unittests_run work with component=shared_library. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Using crypto doesn't necessarily mean importing libopenssl.so on component build Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_prefs.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base.isolate
diff --git a/base/base.isolate b/base/base.isolate
index c92a14b650ba67a0a38b0fdf0fdb955e96586c81..bfa81fe760df26edc4a8709501c16c4c51f295ca 100644
--- a/base/base.isolate
+++ b/base/base.isolate
@@ -8,7 +8,6 @@
'isolate_dependency_tracked': [
'<(PRODUCT_DIR)/lib/libbase.so',
'<(PRODUCT_DIR)/lib/libbase_i18n.so',
- '<(PRODUCT_DIR)/lib/libbase_prefs.so',
],
},
}],
@@ -17,7 +16,6 @@
'isolate_dependency_tracked': [
'<(PRODUCT_DIR)/libbase.dylib',
'<(PRODUCT_DIR)/libbase_i18n.dylib',
- '<(PRODUCT_DIR)/libbase_prefs.dylib',
],
},
}],
@@ -26,13 +24,31 @@
'isolate_dependency_tracked': [
'<(PRODUCT_DIR)/base.dll',
'<(PRODUCT_DIR)/base_i18n.dll',
- '<(PRODUCT_DIR)/base_prefs.dll',
],
},
}],
],
+ # Important note:
+ # Running:
+ # 1. GYP_DEFINES=component=shared_library build/gyp_chromium
+ # 2. ninja -C out/Debug base
+ # will result with only libbase.so being built. Building base by itself won't
+ # force the build of icu or nss. This is because base is not usable by itself.
+ # But on the other hand any test that includes base will be building and
+ # loading at runtime both icu and nss. So define here what is brought by
+ # importing base, not what base would load at runtime.
+ #
+ # There is no such thing as direct_dependent in .isolate, so it's not the best
+ # format to describe this kind of thing. But as a user of base.so, the user
+ # will be importing these other libraries:
'includes': [
+ # While the target 'base' doesn't depend on ../build/linux/system.gyp:ssl
+ # itself, virtually all targets using it has to include
+ # ../third_party/nss/ssl.gyp:libssl through system.gyp.
'../build/linux/system.isolate',
+ # While the target 'base' doesn't depend on ../third_party/icu/icu.gyp
+ # itself, virtually all targets using it has to include icu. The only
+ # exception is the Windows sandbox (?).
'../third_party/icu/icu.isolate',
],
}
« no previous file with comments | « no previous file | base/base_prefs.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698