Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134003003: Revert of video: On ChromeOS don't assume GLX always. (Closed)

Created:
6 years, 11 months ago by Marijn Kruisselbrink
Modified:
6 years, 11 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, chromium-apps-reviews_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/132503002/ Reason for revert: This seems to cause WebRtcBrowserTest to fail on Win7 debug bots TBR=piman@chromium.org,fischman@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true BUG=270918 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244169

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M chrome/browser/media/chrome_webrtc_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/media/webrtc_aecdump_browsertest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M content/common/gpu/media/gpu_video_decode_accelerator.cc View 2 chunks +1 line, -8 lines 0 comments Download
M content/common/gpu/media/video_decode_accelerator_unittest.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Marijn Kruisselbrink
Created Revert of video: On ChromeOS don't assume GLX always.
6 years, 11 months ago (2014-01-10 15:19:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mek@chromium.org/134003003/1
6 years, 11 months ago (2014-01-10 15:20:10 UTC) #2
commit-bot: I haz the power
Change committed as 244169
6 years, 11 months ago (2014-01-10 15:20:33 UTC) #3
Marijn Kruisselbrink
6 years, 11 months ago (2014-01-10 15:29:57 UTC) #4
Message was sent while issue was closed. 
The test output from the failing test:

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%28...

WebrtcBrowserTest.TestGetUserMediaConstraints (run #1):
[ RUN      ] WebrtcBrowserTest.TestGetUserMediaConstraints
[2244:3756:0110/014505:5819898:ERROR:desktop_root_window_host_win.cc(757)] NOT
IMPLEMENTED
[2244:3756:0110/014512:5826418:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014516:5830443:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014516:5830459:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014517:5831894:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014521:5835935:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014522:5836122:ERROR:navigation_entry_screenshot_manager.cc(147)]
Invalid entry with unique id: 1
[2244:3756:0110/014523:5837885:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014523:5837885:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014526:5840318:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014527:5841597:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014530:5844889:ERROR:navigation_entry_screenshot_manager.cc(147)]
Invalid entry with unique id: 2
[2244:3756:0110/014534:5848664:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014534:5848680:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014536:5850146:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014537:5851191:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014539:5853906:ERROR:navigation_entry_screenshot_manager.cc(147)]
Invalid entry with unique id: 3
[2244:3756:0110/014542:5856308:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014542:5856324:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014544:5858055:INFO:CONSOLE(56)] "Done looking at video in
element local-view", source:
http://127.0.0.1:53976/media/webrtc_test_utilities.js (56)
[2244:3756:0110/014545:5859350:INFO:CONSOLE(40)] "Looking at video in element
local-view", source: http://127.0.0.1:53976/media/webrtc_test_utilities.js (40)
[2244:3756:0110/014547:5861862:ERROR:navigation_entry_screenshot_manager.cc(147)]
Invalid entry with unique id: 4
[544/544] WebrtcBrowserTest.TestGetUserMediaConstraints (TIMED OUT)

Powered by Google App Engine
This is Rietveld 408576698