Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1340023003: Fix printing of types and do some cleanups. (Closed)

Created:
5 years, 3 months ago by neis
Modified:
5 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix printing of types and do some cleanups. R=jarin BUG= Committed: https://crrev.com/76ad8ffa00c3778bdc8cfc27c090b3d75f365ec5 Cr-Commit-Position: refs/heads/master@{#30728}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -29 lines) Patch
M src/types.h View 1 chunk +4 lines, -4 lines 0 comments Download
M src/types.cc View 9 chunks +25 lines, -25 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Jarin
lgtm
5 years, 3 months ago (2015-09-15 05:46:33 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340023003/1
5 years, 3 months ago (2015-09-15 05:46:46 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 06:12:00 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1340023003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1340023003/1
5 years, 3 months ago (2015-09-15 06:40:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 06:41:59 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 06:42:08 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/76ad8ffa00c3778bdc8cfc27c090b3d75f365ec5
Cr-Commit-Position: refs/heads/master@{#30728}

Powered by Google App Engine
This is Rietveld 408576698