Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issue 1339943003: Revert "Report data usage UMA for Chrome services" (Closed)

Created:
5 years, 3 months ago by dcheng
Modified:
5 years, 3 months ago
Reviewers:
CC:
chromium-reviews, tim+watch_chromium.org, cbentzel+watch_chromium.org, sdefresne+watchlist_chromium.org, droger+watchlist_chromium.org, zea+watch_chromium.org, bondd+autofillwatch_chromium.org, rouslan+autofill_chromium.org, blundell+watchlist_chromium.org, maxbogue+watch_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org, pvalenzuela+watch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, asvitkine+watch_chromium.org, estade+watch_chromium.org, groby+spellwatch_chromium.org, plaree+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Report data usage UMA for Chrome services" This reverts commit aa789c8328a65922859dfd8ca2d9b18212dc3c94. Broken compile: ../../sync/tools/sync_client.cc:408:32: error: too few arguments to function call, expected 2, have 1 post_factory->Init(kUserAgent); ~~~~~~~~~~~~~~~~~~ ^ BUG=527304 Committed: https://crrev.com/294165fa24917221f3738f5ef5707f3bf4b25678 Cr-Commit-Position: refs/heads/master@{#348564}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -236 lines) Patch
M chrome/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profiles/profile_downloader.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/spellchecker/feedback_sender.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spelling_service_client.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/sync/glue/sync_backend_host_core.cc View 4 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.h View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/sync/test/test_http_bridge_factory.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_download_manager.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/autofill/core/browser/wallet/real_pan_wallet_client.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.h View 1 chunk +0 lines, -13 lines 0 comments Download
M components/data_use_measurement/core/data_use_user_data.cc View 1 chunk +0 lines, -26 lines 0 comments Download
M components/domain_reliability.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/uploader.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/google.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/google/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/google/core/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/google/core/browser/google_url_tracker.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M components/invalidation.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/impl/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/impl/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/invalidation/impl/gcm_network_channel.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/metrics.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/net/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/metrics/net/net_metrics_log_uploader.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/omnibox.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox/browser/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/omnibox/browser/base_search_provider.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/omnibox/browser/search_provider.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/omnibox/browser/zero_suggest_provider.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/device_management_service.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/core/common/cloud/user_info_fetcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/policy/policy_common.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/rappor.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/rappor/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/rappor/log_uploader.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/translate.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/core/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_url_fetcher.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M components/variations.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M components/variations/service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M components/variations/service/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M components/variations/service/variations_service.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M sync/internal_api/http_bridge.cc View 4 chunks +6 lines, -13 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 5 chunks +8 lines, -12 lines 0 comments Download
M sync/internal_api/public/http_bridge.h View 4 chunks +2 lines, -12 lines 0 comments Download
M sync/internal_api/public/http_post_provider_factory.h View 2 chunks +1 line, -9 lines 0 comments Download
M sync/internal_api/sync_manager_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M sync/internal_api/syncapi_server_connection_manager_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.h View 2 chunks +1 line, -4 lines 0 comments Download
M sync/test/fake_server/fake_server_http_post_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +1 line, -27 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/294165fa24917221f3738f5ef5707f3bf4b25678 Cr-Commit-Position: refs/heads/master@{#348564}
5 years, 3 months ago (2015-09-14 05:38:00 UTC) #1
dcheng
Committed patchset #1 (id:1) manually as 294165fa24917221f3738f5ef5707f3bf4b25678 (tree was closed).
5 years, 3 months ago (2015-09-14 05:38:23 UTC) #2
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:29:41 UTC) #3
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/294165fa24917221f3738f5ef5707f3bf4b25678
Cr-Commit-Position: refs/heads/master@{#348564}

Powered by Google App Engine
This is Rietveld 408576698