Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(637)

Issue 133993010: Merged r18805 into trunk branch. (Closed)

Created:
6 years, 11 months ago by Jakob Kummerow
Modified:
6 years, 11 months ago
Reviewers:
Michael Achenbach
CC:
v8-dev
Visibility:
Public.

Description

Merged r18805 into trunk branch. Revert broken ArrayPop changes BUG=chromium:337686 LOG=N R=machenbach@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18807

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -183 lines) Patch
M src/arm/code-stubs-arm.cc View 1 chunk +0 lines, -15 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 1 chunk +73 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +0 lines, -82 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +70 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/mips/code-stubs-mips.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 chunk +72 lines, -0 lines 0 comments Download
M src/stub-cache.h View 2 chunks +17 lines, -0 lines 0 comments Download
M src/stub-cache.cc View 3 chunks +57 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/code-stubs-x64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 chunk +71 lines, -0 lines 0 comments Download
M test/mjsunit/object-seal.js View 1 chunk +2 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-array-pop-deopt.js View 1 chunk +0 lines, -41 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jakob Kummerow
6 years, 11 months ago (2014-01-24 09:08:57 UTC) #1
Michael Achenbach
On 2014/01/24 09:08:57, Jakob wrote: lgtm
6 years, 11 months ago (2014-01-24 09:33:03 UTC) #2
Jakob Kummerow
6 years, 11 months ago (2014-01-24 09:33:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18807.

Powered by Google App Engine
This is Rietveld 408576698