Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Unified Diff: pkg/http/lib/src/base_request.dart

Issue 133993009: pkg/http: fixed analyzer warnings (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: nits Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/http/lib/src/utils.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http/lib/src/base_request.dart
diff --git a/pkg/http/lib/src/base_request.dart b/pkg/http/lib/src/base_request.dart
index e75ef156f00f2a2b7d35e7b47d9372c8f66c4ce7..72edbe288f4ed00dcc464ce7cc2a2491fc638146 100644
--- a/pkg/http/lib/src/base_request.dart
+++ b/pkg/http/lib/src/base_request.dart
@@ -32,7 +32,7 @@ abstract class BaseRequest {
int _contentLength = -1;
set contentLength(int value) {
- _checkFinalized();
+ _baseCheckFinalized();
_contentLength = value;
}
@@ -42,7 +42,7 @@ abstract class BaseRequest {
bool _persistentConnection = true;
set persistentConnection(bool value) {
- _checkFinalized();
+ _baseCheckFinalized();
_persistentConnection = value;
}
@@ -52,7 +52,7 @@ abstract class BaseRequest {
bool _followRedirects = true;
set followRedirects(bool value) {
- _checkFinalized();
+ _baseCheckFinalized();
_followRedirects = value;
}
@@ -63,7 +63,7 @@ abstract class BaseRequest {
int _maxRedirects = 5;
set maxRedirects(int value) {
- _checkFinalized();
+ _baseCheckFinalized();
_maxRedirects = value;
}
@@ -122,8 +122,9 @@ abstract class BaseRequest {
});
}
- /// Throws an error if this request has been finalized.
- void _checkFinalized() {
+ // Throws an error if this request has been finalized.
+ // TODO(nweiz): rename to _checkFinalized once 16029 is resolved
+ void _baseCheckFinalized() {
if (!finalized) return;
throw new StateError("Can't modify a finalized Request.");
}
« no previous file with comments | « no previous file | pkg/http/lib/src/utils.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698