Issue 133993008: Only use SVG Elements for SVG animation events

Issue 133993008: Only use SVG Elements for SVG animation events (Closed)

Created:
6 years, 11 months ago by pdr.

Modified:
6 years, 11 months ago

Reviewers:
pavane, Stephen Chennney, fmalita_google_do_not_use, abarth-chromium

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), darktears, pdr, Stephen Chennney, Steve Block, dino_apple.com, Eric Willigers

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Only use SVG Elements for SVG animation events This patch fixes a regression from [1] where we failed to check that the animation target was an SVG element. This patch ensures event bases are SVGElements in SVGSMILElement::eventBaseFor. [1] https://src.chromium.org/viewvc/blink?view=rev&revision=164697 BUG=333431 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164921

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -6 lines)			Patch
A	LayoutTests/svg/animations/non-svg-eventbase-crash.html	View	1 chunk	+17 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/animations/non-svg-eventbase-crash-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/svg/animation/SVGSMILElement.cpp	View	4 chunks	+8 lines, -5 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/133993008/1

6 years, 11 months ago (2014-01-10 23:39:30 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=7216

6 years, 11 months ago (2014-01-11 00:35:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/133993008/1

6 years, 11 months ago (2014-01-11 01:08:46 UTC) #5

Message was sent while issue was closed.

Change committed as 164921

Expand Messages | Collapse Messages