Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 133993004: Fix mac bot specific performance regression by reverting set of patches (Closed)

Created:
6 years, 11 months ago by atreat
Modified:
6 years, 11 months ago
Reviewers:
esprehn, Inactive, eseidel
CC:
blink-reviews, loislo+blink_chromium.org, sof, eae+blinkwatch, yurys+blink_chromium.org, abarth-chromium, dglazkov+blink, adamk+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix mac bot specific performance regression by reverting set of patches Fix mac bot specific performance regression by reverting set of patches related to dom tree traversal. These patches were implicated for a mac specific regression. Unfortunately, I can not reproduce locally because I do not have a mac and the clang build for linux is not working. There also does not exist any mac try bot for performance tests. BUG=332443, 331880 TBR=esprehn@chromium.org, eseidel@chromium.org, ch.dumez@samsung.com **** Revert "Get rid of the overloads on templated traversal methods for clarity and safety" This reverts commit a681509a3b0e327f7a46f8150c223ce061879256. **** Revert "Remove no longer used methods nextAncestorSibling() from NodeTraversal.h" This reverts commit 6c7d7c149ef4e29b90de2abf117e0a7287908053. **** Revert "We should unify various forms of tree traversal in DOM" This reverts commit f6f4d7a060b6d8ea5242707a3264b5b17825ea05. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164888

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -148 lines) Patch
M Source/core/dom/Node.h View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/NodeTraversal.h View 2 chunks +50 lines, -12 lines 0 comments Download
M Source/core/dom/NodeTraversal.cpp View 1 chunk +23 lines, -0 lines 0 comments Download
M Source/core/dom/StyleEngine.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLImport.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/wtf/TreeNode.h View 5 chunks +49 lines, -110 lines 0 comments Download
M Source/wtf/TreeNodeTest.cpp View 8 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/adam.treat@samsung.com/133993004/1
6 years, 11 months ago (2014-01-10 15:51:18 UTC) #1
atreat
Chris let me know that since it is a revert I should use TBR and ...
6 years, 11 months ago (2014-01-10 15:51:46 UTC) #2
Inactive
Since this is a revert, you can TBR. But lgtm for core/
6 years, 11 months ago (2014-01-10 15:52:19 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-10 18:47:08 UTC) #4
Message was sent while issue was closed.
Change committed as 164888

Powered by Google App Engine
This is Rietveld 408576698