Issue 133993003: Remove prerender::Config::https_allowed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 133993003: Remove prerender::Config::https_allowed. (Closed)

Created:
6 years, 11 months ago by davidben

Modified:
6 years, 11 months ago

Reviewers:
mmenke

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, davidben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove prerender::Config::https_allowed. We've been happy to prerender https URLs for quite some time now. BUG=none TEST=no behavior change Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244206

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -14 lines)			Patch
M	chrome/browser/prerender/prerender_browsertest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_config.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	chrome/browser/prerender/prerender_config.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_contents.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/prerender/prerender_final_status.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/133993003/1

6 years, 11 months ago (2014-01-10 15:51:52 UTC) #3

davidben

On 2014/01/10 15:44:53, mmenke wrote: > LGTM! Surprised there was no test for that case. ...

6 years, 11 months ago (2014-01-10 15:53:25 UTC) #4

Message was sent while issue was closed.

Change committed as 244206

Expand Messages | Collapse Messages