Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 1339923006: Set clip children in LayerTreeHostCommonTest.RenderSurfaceWithUnclippedDescendantsClipsSubtree (Closed)

Created:
5 years, 3 months ago by jaydasika
Modified:
5 years, 2 months ago
Reviewers:
ajuma
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set clip children explicitly in LayerTreeHostCommonTest.RenderSurfaceWithUnclippedDescendantsClipsSubtree. clip parent is set in the test. We also need to explicitly set clip_children of clip parent. The test crashes with this change. The fix is to set unclipped surface of a clip node to be equal to the negation of ancestor clips subtree. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e9d0970c4ff069bc74194ae9a457c54b6938c98a Cr-Commit-Position: refs/heads/master@{#348805}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M cc/trees/layer_tree_host_common_unittest.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
jaydasika
5 years, 3 months ago (2015-09-14 16:02:01 UTC) #2
ajuma
lgtm
5 years, 3 months ago (2015-09-14 17:05:27 UTC) #3
ajuma
https://codereview.chromium.org/1339923006/diff/1/cc/trees/layer_tree_host_common_unittest.cc File cc/trees/layer_tree_host_common_unittest.cc (right): https://codereview.chromium.org/1339923006/diff/1/cc/trees/layer_tree_host_common_unittest.cc#newcode7892 cc/trees/layer_tree_host_common_unittest.cc:7892: std::set<LayerImpl*>* clip_children = new std::set<LayerImpl*>; Please use a scoped_ptr ...
5 years, 3 months ago (2015-09-14 17:07:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923006/20001
5 years, 3 months ago (2015-09-14 22:20:20 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/40537)
5 years, 3 months ago (2015-09-14 23:46:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339923006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339923006/20001
5 years, 3 months ago (2015-09-15 00:53:21 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 01:26:50 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e9d0970c4ff069bc74194ae9a457c54b6938c98a Cr-Commit-Position: refs/heads/master@{#348805}
5 years, 3 months ago (2015-09-15 01:27:38 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:40:57 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e9d0970c4ff069bc74194ae9a457c54b6938c98a
Cr-Commit-Position: refs/heads/master@{#348805}

Powered by Google App Engine
This is Rietveld 408576698