Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1339783003: Revert of Add logging to profile downloader to diagnose Android FR issue. (Closed)

Created:
5 years, 3 months ago by Thiemo Nagel
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add logging to profile downloader to diagnose Android FR issue. (patchset #1 id:1 of https://codereview.chromium.org/1326273003/ ) Reason for revert: Reverting because of reproducible crash, cf. https://crbug.com/530453. Original issue's description: > Add logging to profile downloader to diagnose Android FR issue. > > This is a very temporary fix that will be reverted in a few days when the additional information has been used to pinpoint the bug. > > BUG=500854, 530453 > > Committed: https://crrev.com/55e6026b5e2016626cf3abf126e55e421e0aa2b2 > Cr-Commit-Position: refs/heads/master@{#347932} TBR=rogerta@chromium.org,anthonyvd@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=500854, 530453 Committed: https://crrev.com/daad921a8497b37f14d8e2eba438245f08683ef9 Cr-Commit-Position: refs/heads/master@{#348591}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -13 lines) Patch
M chrome/browser/profiles/profile_downloader.cc View 3 chunks +6 lines, -11 lines 0 comments Download
M components/signin/core/browser/account_fetcher_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Thiemo Nagel
Created Revert of Add logging to profile downloader to diagnose Android FR issue.
5 years, 3 months ago (2015-09-14 09:02:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339783003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339783003/1
5 years, 3 months ago (2015-09-14 09:02:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 09:02:50 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/daad921a8497b37f14d8e2eba438245f08683ef9 Cr-Commit-Position: refs/heads/master@{#348591}
5 years, 3 months ago (2015-09-14 09:03:25 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:31:09 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/daad921a8497b37f14d8e2eba438245f08683ef9
Cr-Commit-Position: refs/heads/master@{#348591}

Powered by Google App Engine
This is Rietveld 408576698