Export various dbus::Property template specializations.

Export various dbus::Property template specializations.

BUG=409111
R=stevenjb@chromium.org

Committed: https://crrev.com/40855d43fa71c215829b53a1034b1b653b4b8557
Cr-Commit-Position: refs/heads/master@{#348536}

[dcheng, 2015-09-11 21:31:53]

dcheng@chromium.org changed reviewers:
+ stevenjb@chromium.org, thakis@chromium.org

[dcheng, 2015-09-11 21:31:53]

I'm not sure why, but when building locally, I consistently see errors like
this:
../../dbus/property_unittest.cc:400: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > >::value() const'
../../dbus/property_unittest.cc:407: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > >::~Property()'
../../dbus/property_unittest.cc:422: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > >::Property()'
../../dbus/property_unittest.cc:423: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > >
>::ReplaceSetValueForTesting(std::__1::vector<std::__1::pair<std::__1::vector<unsigned
char, std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > const&)'
../../dbus/property_unittest.cc:428: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > >::value() const'
../../dbus/property_unittest.cc:429: error: undefined reference to
'dbus::Property<std::__1::vector<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short>,
std::__1::allocator<std::__1::pair<std::__1::vector<unsigned char,
std::__1::allocator<unsigned char> >, unsigned short> > > >::~Property()'
../../dbus/property_unittest.cc:39: error: undefined reference to
'dbus::Property<std::__1::vector<unsigned char, std::__1::allocator<unsigned
char> > >::Property()'
../../dbus/property_unittest.cc:32: error: undefined reference to
'dbus::Property<std::__1::vector<unsigned char, std::__1::allocator<unsigned
char> > >::~Property()'


I'm not building with any particularly interesting gyp defines:
asan=1
clang=1
component=shared_library
dcheck_always_on=1
use_goma=1

Have we had to make similar fixes elsewhere? Or is something just really broken
on my machine?

[Nico, 2015-09-11 21:38:53]

(this is https://code.google.com/p/chromium/issues/detail?id=409111)

[dcheng, 2015-09-11 21:39:53]

On 2015/09/11 at 21:38:53, thakis wrote:
> (this is https://code.google.com/p/chromium/issues/detail?id=409111)

Updated the CL description to reference that bug.

[stevenjb, 2015-09-11 21:58:47]

lgtm

[dcheng, 2015-09-11 22:10:51]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-11 22:12:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/1

[commit-bot: I haz the power, 2015-09-11 22:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 22:14:36]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2015-09-11 22:39:48]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-09-11 22:39:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1339763003/#ps20001
(title: "Git is magic")

[commit-bot: I haz the power, 2015-09-11 22:40:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-11 23:16:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-11 23:16:56]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-11 23:22:05]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-11 23:22:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 00:12:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:12:23]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 00:17:50]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:18:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 00:28:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:28:41]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 00:50:08]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 00:50:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 01:59:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 01:59:53]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 03:12:15]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 03:12:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 04:28:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 04:28:01]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 05:20:09]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 05:20:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 07:17:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 07:17:03]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 16:18:35]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 16:18:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-12 22:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-12 22:20:28]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dcheng, 2015-09-12 22:49:39]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-09-12 22:49:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/20001

[commit-bot: I haz the power, 2015-09-13 04:50:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-13 04:50:50]

Try jobs failed on following builders:
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2015-09-13 06:37:01]

Patchset 2 (id:??) landed as
https://crrev.com/40855d43fa71c215829b53a1034b1b653b4b8557
Cr-Commit-Position: refs/heads/master@{#348536}

[dcheng, 2015-09-13 06:37:16]

Committed patchset #2 (id:20001) manually as
40855d43fa71c215829b53a1034b1b653b4b8557 (presubmit successful).

[spang, 2015-09-14 17:46:56]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1337113005/ by spang@chromium.org.

The reason for reverting is: Does not compile with component=shared_library with
CrOS compiler

../../dbus/property.h:437:42: error: type attributes ignored after type is
already defined [-Werror=attributes]
 extern template class CHROME_DBUS_EXPORT Property<uint8>;
                                          ^
../../dbus/property.h:447:42: error: type attributes ignored after type is
already defined [-Werror=attributes]
 extern template class CHROME_DBUS_EXPORT Property<bool>;

Repro steps:
  cros chrome-sdk --board=amd64-generic --component
  gclient runhooks
  ninja -C out_amd64-generic/Release chrome
.

[dcheng, 2015-09-15 18:58:17]

PTAL... I added pragmas to suppress GCC's diagnostic for attributes in this
block.

[dcheng, 2015-09-16 17:20:46]

ping!

[dcheng, 2015-09-17 16:50:44]

ping? Anyone?

[Nico, 2015-09-18 17:21:12]

lgtm

[dcheng, 2015-09-18 17:47:48]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-09-18 17:47:48]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2015-09-18 17:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1339763003/#ps60001
(title: "Add a bug comment")

[dcheng, 2015-09-18 17:47:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1339763003/#ps60001
(title: "Add a bug comment")

[commit-bot: I haz the power, 2015-09-18 17:48:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339763003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339763003/60001

[commit-bot: I haz the power, 2015-09-18 18:29:14]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-18 18:30:17]

Patchset 4 (id:??) landed as
https://crrev.com/fc6e2304f630345c79c95291191f4b64880736a1
Cr-Commit-Position: refs/heads/master@{#349717}

[commit-bot: I haz the power, 2015-09-23 12:28:19]

Patchset 4 (id:??) landed as
https://crrev.com/40855d43fa71c215829b53a1034b1b653b4b8557
Cr-Commit-Position: refs/heads/master@{#348536}