Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1339673002: PPC: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Make FlushICache part of Assembler(Base) and take Isolate as parameter. Port 9fc4fc141fa1d1aa1a3ccb901518cdffa0d6d268 R=mlippautz@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=chromium:524425 LOG=N Committed: https://crrev.com/31026cd5a0e192b6b1f79f4b27bcbadca60c265e Cr-Commit-Position: refs/heads/master@{#30698}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -24 lines) Patch
M src/ppc/assembler-ppc-inl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ppc/code-stubs-ppc.h View 1 chunk +3 lines, -2 lines 0 comments Download
M src/ppc/codegen-ppc.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/ppc/cpu-ppc.cc View 2 chunks +2 lines, -16 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339673002/1
5 years, 3 months ago (2015-09-11 14:26:13 UTC) #2
MTBrandyberry
5 years, 3 months ago (2015-09-11 14:28:28 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 15:04:04 UTC) #5
john.yan
lgtm
5 years, 3 months ago (2015-09-11 15:06:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339673002/1
5 years, 3 months ago (2015-09-11 15:07:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 15:10:00 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-11 15:10:10 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31026cd5a0e192b6b1f79f4b27bcbadca60c265e
Cr-Commit-Position: refs/heads/master@{#30698}

Powered by Google App Engine
This is Rietveld 408576698