Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339653005: Remove content-less string IDS_ERRORPAGES_ERROR_CODE. (Closed)

Created:
5 years, 3 months ago by newt (away)
Modified:
5 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove content-less string IDS_ERRORPAGES_ERROR_CODE. This string contains a placeholder and no actual text. It doesn't need to exist. BUG=518020 Committed: https://crrev.com/c3950164bfb0278be2818abc7229ecbd4318f9a2 Cr-Commit-Position: refs/heads/master@{#348824}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M build/ios/grit_whitelist.txt View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Issue 1322353002 Patch 1

Messages

Total messages: 8 (2 generated)
newt (away)
Small cleanup. PTAL.
5 years, 3 months ago (2015-09-15 01:22:46 UTC) #2
Nico
lgtm
5 years, 3 months ago (2015-09-15 01:31:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339653005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339653005/1
5 years, 3 months ago (2015-09-15 01:33:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 02:41:02 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c3950164bfb0278be2818abc7229ecbd4318f9a2 Cr-Commit-Position: refs/heads/master@{#348824}
5 years, 3 months ago (2015-09-15 02:41:55 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:41:59 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c3950164bfb0278be2818abc7229ecbd4318f9a2
Cr-Commit-Position: refs/heads/master@{#348824}

Powered by Google App Engine
This is Rietveld 408576698