Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1339653004: Fixes for 32-bit official GN build. (Closed)

Created:
5 years, 3 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, tfarina, nodir, Bons
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixes for 32-bit official GN build. Uses the host toolchain for the dump symbol and stack walk utilities. Remove the dummy nacl target when nacl is disabled. Previously there was a dummy nacl target but no dummy nacl_helper target. They should be consistent. It turns out we use neither when nacl is disabled, so I removed the existing one. Unrelated: Update GN quick start with a link to the new sites page I made for build arguments. Committed: https://crrev.com/314880aa20d7e71bc01515afa7b9c82e763f4218 Cr-Commit-Position: refs/heads/master@{#348477}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M components/nacl/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/web_view/test_runner/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/gn/docs/quick_start.md View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339653004/1
5 years, 3 months ago (2015-09-11 17:29:29 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-11 18:01:17 UTC) #5
brettw
5 years, 3 months ago (2015-09-11 19:28:02 UTC) #6
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-11 19:49:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339653004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339653004/1
5 years, 3 months ago (2015-09-11 20:03:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-11 20:09:37 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/314880aa20d7e71bc01515afa7b9c82e763f4218 Cr-Commit-Position: refs/heads/master@{#348477}
5 years, 3 months ago (2015-09-11 20:10:17 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:25:57 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/314880aa20d7e71bc01515afa7b9c82e763f4218
Cr-Commit-Position: refs/heads/master@{#348477}

Powered by Google App Engine
This is Rietveld 408576698