Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1339653002: Update gitignore to ignore more GYP things (Closed)

Created:
5 years, 3 months ago by Ted Mielczarek
Modified:
5 years, 3 months ago
Reviewers:
vapier
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Update gitignore to ignore more GYP things Now that we're using gclient everywhere, the hook to run gyp on the Windows projects gets run on Linux, so we get Makefiles strewn around the tree. R=vapier@chromium.org Committed: https://chromium.googlesource.com/breakpad/breakpad/+/f766c4d790491d46b57797d701a3b07cc0fd979c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M .gitignore View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Ted Mielczarek
5 years, 3 months ago (2015-09-11 13:12:52 UTC) #1
vapier
lgtm
5 years, 3 months ago (2015-09-11 17:01:55 UTC) #2
Ted Mielczarek
5 years, 3 months ago (2015-09-11 18:20:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f766c4d790491d46b57797d701a3b07cc0fd979c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698