Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: build/android/envsetup_functions.sh

Issue 133963003: android: Stop adding toolchain dir to PATH. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/bin/bash 1 #!/bin/bash
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # Defines functions for envsetup.sh which sets up environment for building 7 # Defines functions for envsetup.sh which sets up environment for building
8 # Chromium on Android. The build can be either use the Android NDK/SDK or 8 # Chromium on Android. The build can be either use the Android NDK/SDK or
9 # android source tree. Each has a unique init function which calls functions 9 # android source tree. Each has a unique init function which calls functions
10 # prefixed with "common_" that is common for both environment setups. 10 # prefixed with "common_" that is common for both environment setups.
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 export PATH=$PATH:${ANDROID_SDK_ROOT}/platform-tools 61 export PATH=$PATH:${ANDROID_SDK_ROOT}/platform-tools
62 export PATH=$PATH:${ANDROID_SDK_ROOT}/build-tools/\ 62 export PATH=$PATH:${ANDROID_SDK_ROOT}/build-tools/\
63 ${ANDROID_SDK_BUILD_TOOLS_VERSION} 63 ${ANDROID_SDK_BUILD_TOOLS_VERSION}
64 64
65 # This must be set before ANDROID_TOOLCHAIN, so that clang could find the 65 # This must be set before ANDROID_TOOLCHAIN, so that clang could find the
66 # gold linker. 66 # gold linker.
67 # TODO(michaelbai): Remove this path once the gold linker become the default 67 # TODO(michaelbai): Remove this path once the gold linker become the default
68 # linker. 68 # linker.
69 export PATH=$PATH:${CHROME_SRC}/build/android/${toolchain_arch}-gold 69 export PATH=$PATH:${CHROME_SRC}/build/android/${toolchain_arch}-gold
70 70
71 # Must have tools like arm-linux-androideabi-gcc on the path for ninja
72 export PATH=$PATH:${ANDROID_TOOLCHAIN}
73
74 # Add Chromium Android development scripts to system path. 71 # Add Chromium Android development scripts to system path.
75 # Must be after CHROME_SRC is set. 72 # Must be after CHROME_SRC is set.
76 export PATH=$PATH:${CHROME_SRC}/build/android 73 export PATH=$PATH:${CHROME_SRC}/build/android
77 74
78 # TODO(beverloo): Remove these once all consumers updated to --strip-binary. 75 # TODO(beverloo): Remove these once all consumers updated to --strip-binary.
79 export OBJCOPY=$(echo ${ANDROID_TOOLCHAIN}/*-objcopy) 76 export OBJCOPY=$(echo ${ANDROID_TOOLCHAIN}/*-objcopy)
80 export STRIP=$(echo ${ANDROID_TOOLCHAIN}/*-strip) 77 export STRIP=$(echo ${ANDROID_TOOLCHAIN}/*-strip)
81 78
82 # The set of GYP_DEFINES to pass to gyp. Use 'readlink -e' on directories 79 # The set of GYP_DEFINES to pass to gyp. Use 'readlink -e' on directories
83 # to canonicalize them (remove double '/', remove trailing '/', etc). 80 # to canonicalize them (remove double '/', remove trailing '/', etc).
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
319 fi 316 fi
320 export GYP_DEFINES="${DEFINES}" 317 export GYP_DEFINES="${DEFINES}"
321 318
322 export GYP_GENERATORS="android" 319 export GYP_GENERATORS="android"
323 320
324 export GYP_GENERATOR_FLAGS="${GYP_GENERATOR_FLAGS} default_target=All" 321 export GYP_GENERATOR_FLAGS="${GYP_GENERATOR_FLAGS} default_target=All"
325 export GYP_GENERATOR_FLAGS="${GYP_GENERATOR_FLAGS} limit_to_target_all=1" 322 export GYP_GENERATOR_FLAGS="${GYP_GENERATOR_FLAGS} limit_to_target_all=1"
326 323
327 export CHROMIUM_GYP_FILE="${CHROME_SRC}/android_webview/all_webview.gyp" 324 export CHROMIUM_GYP_FILE="${CHROME_SRC}/android_webview/all_webview.gyp"
328 } 325 }
OLDNEW
« no previous file with comments | « no previous file | build/common.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698