android: Stop adding toolchain dir to PATH.

android: Stop adding toolchain dir to PATH.

This seems mostly no longer necessary (at least I can build all targets
in an open-source chrome/android build without problems). I'm guessing
that https://codereview.chromium.org/9693042 made this obsolete.

It was only needed for `as` with clang; pass -B to clang instead
for now (until we switch to clang's integrated assembler).

BUG=330631, 124610
R=torne@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246714

[Nico, 2014-01-23 17:01:46]

ping

[Torne, 2014-01-23 21:48:57]

It was semi-useful in the past for manually invoking
arm-linux-androideabi-{objdump,nm,readelf} and friends, but most people who
build for android use cr now anyway which doesn't expose this PATH setting
outside of cr's environment. I think it's safe to drop this. LGTM.

[Nico, 2014-01-23 23:14:19]

Thanks!

On 2014/01/23 21:48:57, Torne wrote:
> It was semi-useful in the past for manually invoking
> arm-linux-androideabi-{objdump,nm,readelf} and friends

People who want to do this can still add the directory to their path. I'd guess
most folks don't need this. (I usually run `ninja -v` and copy a command line
from there and work with that for build-related stuff)

>, but most people who
> build for android use cr now anyway which doesn't expose this PATH setting
> outside of cr's environment. I think it's safe to drop this. LGTM.

[Nico, 2014-01-23 23:17:21]

Committed patchset #2 manually as r246714 (presubmit successful).