Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1339613002: Explicitly include MacScrollTypes.h in view_messages.h (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly include MacScrollTypes.h in view_messages.h This header is currently included via WebScrollbarTheme.h (which is needed for blink::ScrollerStyle). Explicitly including it makes the dependency clearer. Committed: https://crrev.com/55ed6487742610a8a396e261749badf74e9fb1aa Cr-Commit-Position: refs/heads/master@{#348601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M content/common/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M content/common/view_messages.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (5 generated)
fs
5 years, 3 months ago (2015-09-11 11:32:31 UTC) #2
Greg K
On 2015/09/11 11:32:31, fs wrote: LGTM
5 years, 3 months ago (2015-09-11 16:16:46 UTC) #3
palmer
lgtm
5 years, 3 months ago (2015-09-11 20:18:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339613002/1
5 years, 3 months ago (2015-09-14 07:39:10 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/99250)
5 years, 3 months ago (2015-09-14 07:47:50 UTC) #8
fs
+jochen for target-file DEPS
5 years, 3 months ago (2015-09-14 08:14:03 UTC) #10
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-14 09:48:41 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339613002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339613002/1
5 years, 3 months ago (2015-09-14 10:22:08 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 11:08:45 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/55ed6487742610a8a396e261749badf74e9fb1aa Cr-Commit-Position: refs/heads/master@{#348601}
5 years, 3 months ago (2015-09-14 11:09:28 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:31:37 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/55ed6487742610a8a396e261749badf74e9fb1aa
Cr-Commit-Position: refs/heads/master@{#348601}

Powered by Google App Engine
This is Rietveld 408576698