Issue 1339603006: Subzero: Generate correct code for shifts by a large immediate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1339603006: Subzero: Generate correct code for shifts by a large immediate. (Closed)

Created:
5 years, 3 months ago by Jim Stichnoth

Modified:
5 years, 3 months ago

Reviewers:
Karl, ascull, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Generate correct code for shifts by a large immediate. X86 requires an immediate shift value to fit within 8 bits. It's undefined LLVM behavior if it doesn't (or in fact if the value exceeds the number of bits in the type width), but at least we can produce valid x86 instructions. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4316 R=ascull@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=be4988823a0a069750895c30febd0f01e9477bed

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+52 lines, -1 line)			Patch
	M	src/IceAssemblerX86BaseImpl.h	View	1 2	1 chunk	+4 lines, -1 line	0 comments	Download
	M	tests_lit/llvm2ice_tests/shift.ll	View	1	1 chunk	+48 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Jim Stichnoth

After discussion with John, take a simpler approach of just removing the assembler assert, since ...

5 years, 3 months ago (2015-09-15 20:10:22 UTC) #3

Jim Stichnoth

5 years, 3 months ago (2015-09-16 04:53:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
be4988823a0a069750895c30febd0f01e9477bed (presubmit successful).