Blacklist certain devices from Document Mode.

Default certain devices to Tabbed Mode.

BUG=531677
Committed: https://crrev.com/bc9a812fc6a426dd1becf9fedf3ff0845b127f78
Cr-Commit-Position: refs/heads/master@{#348800}

[aurimas (slooooooooow), 2015-09-14 21:06:15]

aurimas@chromium.org changed reviewers:
+ tedchoc@chromium.org

[aurimas (slooooooooow), 2015-09-14 21:06:16]

PTAL

[aurimas (slooooooooow), 2015-09-15 00:03:14]

aurimas@chromium.org changed reviewers:
+ yusufo@chromium.org

[aurimas (slooooooooow), 2015-09-15 00:03:15]

PTAL

[Yusuf, 2015-09-15 00:08:44]

lgtm once the nits are addressed

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
(right):

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java:231:
for (String supportedModel : BLACKLISTED_SAMSUNG_DEVICES) {
s/supporttedModel/DefaultTabbedModeModel
s/BLACKLISTED_SAMSUNG_DEVICES/DEFAULT_TABBED_MODE_DEVICES

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java:243:
optOutState = 0;
Lets add a constant for this and call it OPT_IN.

[aurimas (slooooooooow), 2015-09-15 00:19:45]

aurimas@chromium.org changed reviewers:
+ newt@chromium.org

[aurimas (slooooooooow), 2015-09-15 00:19:46]

OWNERS review.

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
(right):

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java:231:
for (String supportedModel : BLACKLISTED_SAMSUNG_DEVICES) {
On 2015/09/15 at 00:08:44, Yusuf wrote:
> s/supporttedModel/DefaultTabbedModeModel
> s/BLACKLISTED_SAMSUNG_DEVICES/DEFAULT_TABBED_MODE_DEVICES

Done

https://chromiumcodereview.appspot.com/1339603005/diff/1/chrome/android/java/...
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java:243:
optOutState = 0;
On 2015/09/15 at 00:08:44, Yusuf wrote:
> Lets add a constant for this and call it OPT_IN.

Done

[aurimas (slooooooooow), 2015-09-15 00:20:14]

+newt for OWNERS review.

[newt (away), 2015-09-15 00:29:42]

rubberstamp lgtm

https://chromiumcodereview.appspot.com/1339603005/diff/20001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java
(right):

https://chromiumcodereview.appspot.com/1339603005/diff/20001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/preferences/DocumentModeManager.java:91:
"SM-C105", // Galaxy S4 Zoom
This line looks *very* suspicious.

[aurimas (slooooooooow), 2015-09-15 00:30:29]

The CQ bit was checked by aurimas@chromium.org

[aurimas (slooooooooow), 2015-09-15 00:30:30]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/1339603005/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-09-15 00:31:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339603005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339603005/20001

[commit-bot: I haz the power, 2015-09-15 01:20:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-15 01:20:46]

Patchset 2 (id:??) landed as
https://crrev.com/bc9a812fc6a426dd1becf9fedf3ff0845b127f78
Cr-Commit-Position: refs/heads/master@{#348800}

[commit-bot: I haz the power, 2015-09-23 12:40:46]

Patchset 2 (id:??) landed as
https://crrev.com/bc9a812fc6a426dd1becf9fedf3ff0845b127f78
Cr-Commit-Position: refs/heads/master@{#348800}