Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issue 1339603003: CMake bot script (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake bot script - Add CMake v3.3.1 (latest) to DEPS. - Add cmake/bot-cmake.sh to bootstrap CMake then build Skia using that. Works on my Mac and Linux box, both with no system CMake installation. CMake will be ~100M on disk. The first bootstrap takes a couple minutes, and a no-op re-run of bot-cmake.sh takes 15-20 seconds. I thought about having bot-cmake.sh fetch CMake instead of DEPS, but I'm not sure I can handle updates, etc. as robustly as it can. This will only work on Linux and Mac. CMake requires an older CMake on Windows. It doesn't have an equivalent ./bootstrap there. Will have to think about how Windows bots will work! BUG=skia:4269 Committed: https://skia.googlesource.com/skia/+/a22eabedef0cc1256f8c60e58e7a1cbd0bd1db9b

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : drop ccache requirement #

Patch Set 4 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A cmake/cmake_build View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
5 years, 3 months ago (2015-09-14 16:48:35 UTC) #2
borenet
LGTM, but I think I'd prefer the script be called "cmake_build", following the example of ...
5 years, 3 months ago (2015-09-14 16:54:13 UTC) #3
mtklein_C
On 2015/09/14 16:54:13, borenet wrote: > LGTM, but I think I'd prefer the script be ...
5 years, 3 months ago (2015-09-14 16:56:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339603003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339603003/60001
5 years, 3 months ago (2015-09-14 16:56:31 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 17:02:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/a22eabedef0cc1256f8c60e58e7a1cbd0bd1db9b

Powered by Google App Engine
This is Rietveld 408576698