Vector ICs: gyp flag to run with vector-stores on.

Vector ICs: gyp flag to run with vector-stores on.

This is so we can build with the flag on in the snapshot.
D8 then needs to be run with --vector-stores.

BUG=
R=machenbach@chromium.org

Committed: https://crrev.com/18bba7cb41d3e4073cdd375e26f17c2f4ee8bb82
Cr-Commit-Position: refs/heads/master@{#30692}

[mvstanton, 2015-09-11 09:11:20]

Hi Michael, here is the change we discussed, thanks for the look!
--Michael

[Michael Achenbach, 2015-09-11 09:18:46]

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp#newcode33
tools/gyp/v8.gyp:33: 'v8_vector_stores%': "",
Rather put
'v8_vector_stores%': 0,
as a default

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp#newcode210
tools/gyp/v8.gyp:210: 'mksnapshot_flags': ['--vector-stores', ''],
Does it need the second empty parameter to work?

I'm also not so sure if the list will be accumulated. Could you check that this
works with v8_random_seed? I.e. set v8_random_seed=1234 and v8_vector_stores=1
and check if both are used together...

If they weren't accumulated, it looks like already some other code here wouldn't
work.

[mvstanton, 2015-09-11 09:31:38]

Thanks for the comments, addressed...

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp
File tools/gyp/v8.gyp (right):

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp#newcode33
tools/gyp/v8.gyp:33: 'v8_vector_stores%': "",
On 2015/09/11 09:18:46, Michael Achenbach wrote:
> Rather put
> 'v8_vector_stores%': 0,
> as a default

Done.

https://codereview.chromium.org/1339593002/diff/1/tools/gyp/v8.gyp#newcode210
tools/gyp/v8.gyp:210: 'mksnapshot_flags': ['--vector-stores', ''],
On 2015/09/11 09:18:46, Michael Achenbach wrote:
> Does it need the second empty parameter to work?
> 
> I'm also not so sure if the list will be accumulated. Could you check that
this
> works with v8_random_seed? I.e. set v8_random_seed=1234 and v8_vector_stores=1
> and check if both are used together...
> 
> If they weren't accumulated, it looks like already some other code here
wouldn't
> work.

Thanks, I removed the extra '' parameter. Also verified that these conditions
accumulate correctly.

[mvstanton, 2015-09-11 09:31:39]

Thanks for the comments, addressed...

[Michael Achenbach, 2015-09-11 09:42:28]

lgtm

[mvstanton, 2015-09-11 09:43:19]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2015-09-11 09:43:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339593002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339593002/20001

[commit-bot: I haz the power, 2015-09-11 10:00:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-11 10:00:26]

Patchset 2 (id:??) landed as
https://crrev.com/18bba7cb41d3e4073cdd375e26f17c2f4ee8bb82
Cr-Commit-Position: refs/heads/master@{#30692}