[Android] Use the right visibility type for PopupWindow handles

[Android] Use the right visibility type for PopupWindow handles

Match the native Android TextView handles by using the same PopupWindow
visibility type, namely, TYPE_APPLICATION_SUB_PANEL.

BUG=528365
Committed: https://crrev.com/e8619bf8843096c2243a524713888c9ad993b807
Cr-Commit-Position: refs/heads/master@{#348757}

[jdduke (slow), 2015-09-14 16:41:37]

jdduke@chromium.org changed reviewers:
+ aurimas@chromium.org

[jdduke (slow), 2015-09-14 16:41:37]

aurimas: PTAL, thanks.

[aurimas (slooooooooow), 2015-09-14 21:17:11]

lgtm

https://chromiumcodereview.appspot.com/1339433003/diff/20001/content/public/a...
File
content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
(right):

https://chromiumcodereview.appspot.com/1339433003/diff/20001/content/public/a...
content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java:147:
} catch (NoSuchMethodException e) {
You can replace all these with:

        catch (NoSuchMethodException | IllegalAccessException |
InvocationTargetException
                | RuntimeException e) {
        }

You can also drop IllegalArgumentException as that is covered by
RuntimeException.

[jdduke (slow), 2015-09-14 21:47:20]

The CQ bit was checked by jdduke@chromium.org

[jdduke (slow), 2015-09-14 21:47:20]

The patchset sent to the CQ was uploaded after l-g-t-m from aurimas@chromium.org
Link to the patchset: https://codereview.chromium.org/1339433003/#ps40001
(title: "Code review")

[jdduke (slow), 2015-09-14 21:48:19]

https://codereview.chromium.org/1339433003/diff/20001/content/public/android/...
File
content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java
(right):

https://codereview.chromium.org/1339433003/diff/20001/content/public/android/...
content/public/android/java/src/org/chromium/content/browser/input/PopupTouchHandleDrawable.java:147:
} catch (NoSuchMethodException e) {
On 2015/09/14 21:17:11, aurimas wrote:
> You can replace all these with:
> 
>         catch (NoSuchMethodException | IllegalAccessException |
> InvocationTargetException
>                 | RuntimeException e) {
>         }
> 
> You can also drop IllegalArgumentException as that is covered by
> RuntimeException.

Done.

[commit-bot: I haz the power, 2015-09-14 21:48:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1339433003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1339433003/40001

[commit-bot: I haz the power, 2015-09-14 23:14:09]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-14 23:15:16]

Patchset 3 (id:??) landed as
https://crrev.com/e8619bf8843096c2243a524713888c9ad993b807
Cr-Commit-Position: refs/heads/master@{#348757}

[commit-bot: I haz the power, 2015-09-23 12:38:42]

Patchset 3 (id:??) landed as
https://crrev.com/e8619bf8843096c2243a524713888c9ad993b807
Cr-Commit-Position: refs/heads/master@{#348757}