Gamepad API support for chrome on android

content/browser/gamepad/gamepad_platform_data_fetcher_android.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.

[Ted C, 2014/04/16 23:36:53]

no (c)

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:
Is it?
I notived that other files (gamepad_platform_data_fetcher_linux.h) are using
this type of copyright "// Copyright (c) 2012"
If you think it should be removed, i can do that.

[kbalazs, 2014/04/18 15:21:20]

(c) is deprecated. It's there in a lot of files but new files shouldn't use.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+// Define the data fetcher that GamepadProvider will use for android port.
+// (GamepadPlatformDataFetcher).
+
+#ifndef CONTENT_BROWSER_GAMEPAD_GAMEPAD_PLATFORM_DATA_FETCHER_ANDROID_H_
+#define CONTENT_BROWSER_GAMEPAD_GAMEPAD_PLATFORM_DATA_FETCHER_ANDROID_H_
+
+#include <jni.h>
+
+#include "base/android/jni_android.h"
+#include "content/browser/gamepad/gamepad_data_fetcher.h"
+#include "content/browser/gamepad/gamepad_provider.h"
+#include "content/browser/gamepad/gamepad_standard_mappings.h"
+
+#include "third_party/WebKit/public/platform/WebGamepads.h"

[Ted C, 2014/04/16 23:36:53]

no blank line above this.

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:

Done.

+
+namespace content {
+using blink::WebGamepad;

[Ted C, 2014/04/16 23:36:53]

you are fully qualifying blink::WebGamepads, so I don't think you need these
(and it doesn't look like you use blink::WebGamepad at all in this file).

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:

Removed it.

+using blink::WebGamepads;
+
+class GamepadPlatformDataFetcherAndroid : public GamepadDataFetcher {
+ public:
+  GamepadPlatformDataFetcherAndroid();
+  ~GamepadPlatformDataFetcherAndroid();
+
+  // Method for sending pause hints to the JNI interface. Runs on
+  // polling_thread_.

[Ted C, 2014/04/16 23:36:53]

polling_thread_ is a private class variable in gamepad_provider.cc, so I don't
think you should reference it here.

Maybe just say runs on the background polling thread.

And this comment doesn't really seem necessary to me.  It seems more an
implementation description than when this should be used.  I'd probably just
drop it.

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:

Dropping the comment now.

+  virtual void PauseHint(bool ispaused) OVERRIDE;

[Ted C, 2014/04/16 23:36:53]

is_paused or just paused to match the overridden method signature

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:

Using paused

+
+  virtual void GetGamepadData(blink::WebGamepads* pads,
+                              bool devices_changed_hint) OVERRIDE;
+
+  // Registers the JNI methods for GamepadsReader.
+  static bool RegisterGamepadPlatformDataFetcherAndroid(JNIEnv* env);
+
+ private:
+  // Data to fetch into.
+  blink::WebGamepads* gamepads_data_;

[jdduke (slow), 2014/04/16 23:23:44]

I think you can remove this variable now?

[Ted C, 2014/04/16 23:36:53]

this doesn't look used in the implementation

[SaurabhK, 2014/04/18 14:51:57]

On 2014/04/16 23:36:53, Ted C wrote:

Removed.

+
+  DISALLOW_COPY_AND_ASSIGN(GamepadPlatformDataFetcherAndroid);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_GAMEPAD_GAMEPAD_PLATFORM_DATA_FETCHER_ANDROID_H_