Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1339373003: Fix media media_blink_unittest (Closed)

Created:
5 years, 3 months ago by hubbe
Modified:
5 years, 3 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix media media_blink_unittest VideoFrameCompositorTest.NaturalSizeChanged & VideoFrameCompositorTest.OpacityChanged broke while the tests were not running. Most likely because of https://codereview.chromium.org/1299523002/ This fixes the test. Committed: https://crrev.com/602856aa62634b5d70a4b22a6908f2d017b93ab4 Cr-Commit-Position: refs/heads/master@{#348938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M media/blink/video_frame_compositor_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hubbe
I'm not entirely certain this is the *right* way to fix the test, but it ...
5 years, 3 months ago (2015-09-15 17:48:25 UTC) #2
hubbe
I'm not entirely certain this is the *right* way to fix the test, but it ...
5 years, 3 months ago (2015-09-15 17:48:59 UTC) #4
DaleCurtis
This is the correct fix after the previous change. Thanks! lgtm
5 years, 3 months ago (2015-09-15 18:07:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339373003/1
5 years, 3 months ago (2015-09-15 18:12:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 18:24:25 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/602856aa62634b5d70a4b22a6908f2d017b93ab4 Cr-Commit-Position: refs/heads/master@{#348938}
5 years, 3 months ago (2015-09-15 18:25:31 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:47:07 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/602856aa62634b5d70a4b22a6908f2d017b93ab4
Cr-Commit-Position: refs/heads/master@{#348938}

Powered by Google App Engine
This is Rietveld 408576698