Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Issue 133933009: Add the NOTRY command on roll_deps.py (Closed)

Created:
6 years, 11 months ago by hal.canary
Modified:
6 years, 10 months ago
CC:
skia-review_googlegroups.com, rmistry
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add the NOTRY command on roll_deps.py Motivation: The current workflow is to submit via `git cl dcommit`. As we move to automated nightly creation of the DEPS roll CLs, we want to make it easier for the submitter to speed along a clean roll. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=13211

Patch Set 1 #

Total comments: 2

Patch Set 2 : case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M tools/roll_deps.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
hal.canary
I thought I had sent out this CL on Friday. This should make everyone's life ...
6 years, 11 months ago (2014-01-27 20:40:17 UTC) #1
borenet
LGTM if the capitalization is correct. https://codereview.chromium.org/133933009/diff/1/tools/roll_deps.py File tools/roll_deps.py (right): https://codereview.chromium.org/133933009/diff/1/tools/roll_deps.py#newcode749 tools/roll_deps.py:749: 'NOTRY=True\n' Wasn't this ...
6 years, 11 months ago (2014-01-27 20:42:04 UTC) #2
rmistry
https://codereview.chromium.org/133933009/diff/1/tools/roll_deps.py File tools/roll_deps.py (right): https://codereview.chromium.org/133933009/diff/1/tools/roll_deps.py#newcode749 tools/roll_deps.py:749: 'NOTRY=True\n' On 2014/01/27 20:42:04, borenet wrote: > Wasn't this ...
6 years, 11 months ago (2014-01-27 20:59:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/halcanary@google.com/133933009/20001
6 years, 11 months ago (2014-01-27 21:08:31 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-27 22:42:58 UTC) #5
Message was sent while issue was closed.
Change committed as 13211

Powered by Google App Engine
This is Rietveld 408576698