Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 133933007: trychange.py: Use urllib2's urlopen() instead of urllib's. (Closed)

Created:
6 years, 11 months ago by Raphael Kubo da Costa (rakuco)
Modified:
6 years, 10 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

trychange.py: Use urllib2's urlopen() instead of urllib's. urllib.urlopen() has issues with proxies similar to the ones reported in bug 134165 that are not present in urllib2.urlopen() -- namely, it does not perform HTTP tunneling with proxy servers when fetching HTTPS URLs. TEST=Pass --url=https://someurl to trychange.py behind a corporate proxy R=maruel@chromium.org,iannucci@chromium.org,dpranke@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=247914

Patch Set 1 #

Patch Set 2 : Remove --proxy support #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M tests/trychange_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download
M trychange.py View 1 6 chunks +5 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Raphael Kubo da Costa (rakuco)
6 years, 11 months ago (2014-01-27 17:40:15 UTC) #1
M-A Ruel
In practice I only use this code while doing local testing on a temporary local ...
6 years, 11 months ago (2014-01-27 17:45:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/133933007/1
6 years, 11 months ago (2014-01-27 17:46:32 UTC) #3
commit-bot: I haz the power
Presubmit check for 133933007-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 11 months ago (2014-01-27 17:48:21 UTC) #4
Raphael Kubo da Costa (rakuco)
Duh. So urllib2.urlopen() doesn't take the `proxies' argument that urllib.urlopen() does; given that its built-in ...
6 years, 10 months ago (2014-01-28 09:04:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raphael.kubo.da.costa@intel.com/133933007/70001
6 years, 10 months ago (2014-01-30 09:18:15 UTC) #6
commit-bot: I haz the power
Change committed as 247914
6 years, 10 months ago (2014-01-30 09:20:45 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-01-30 09:21:13 UTC) #8
Message was sent while issue was closed.
CQ bit was unchecked on CL. Ignoring.

Powered by Google App Engine
This is Rietveld 408576698