sdk/lib/html/dartium/html_dartium.dart - Issue 13393008: Revert "Optimizing createElement_html"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 13393008: Revert "Optimizing createElement_html" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/html/dartium/html_dartium.dart

diff --git a/sdk/lib/html/dartium/html_dartium.dart b/sdk/lib/html/dartium/html_dartium.dart

index da628c59d6d7bdc089b8df606d69d664be5a6617..d7bb433baf8674dc715cb60500ea248395157e9a 100644

--- a/sdk/lib/html/dartium/html_dartium.dart

+++ b/sdk/lib/html/dartium/html_dartium.dart

@@ -10522,13 +10522,12 @@ class _ElementFactoryProvider {

Element element;

if (temp.children.length == 1) {

- element = temp.$dom_firstChild;

+ element = temp.children[0];

} else if (parentTag == 'html' && temp.children.length == 2) {

// In html5 the root <html> tag will always have a <body> and a <head>,

// even though the inner html only contains one of them.

element = temp.children[tag == 'head' ? 0 : 1];

} else {

- // Throw an exception because too many children.

_singleNode(temp.children);

}

element.remove();

@@ -35087,6 +35086,7 @@ class _PureIsolateTimer implements Timer {

_sendPort = _port.toSendPort();

_port.receive((msg, replyTo) {

assert(msg == _TIMER_PING);

+ assert(replyTo == _HELPER_ISOLATE_PORT);

callback(this);

if (!repeating) _cancel();

});