Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339293002: X87: Make FlushICache part of Assembler(Base) and take Isolate as parameter. (Closed)

Created:
5 years, 3 months ago by chunyang.dai
Modified:
5 years, 3 months ago
Reviewers:
Weiliang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Make FlushICache part of Assembler(Base) and take Isolate as parameter. port 9fc4fc141fa1d1aa1a3ccb901518cdffa0d6d268 (r30695). BUG= Committed: https://crrev.com/8c8c7523c2a6188d552ba35a7948285de0d40705 Cr-Commit-Position: refs/heads/master@{#30743}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/x87/assembler-x87-inl.h View 5 chunks +5 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.h View 1 chunk +1 line, -1 line 0 comments Download
M src/x87/codegen-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x87/macro-assembler-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
ptal
5 years, 3 months ago (2015-09-15 10:15:27 UTC) #2
Weiliang
lgtm
5 years, 3 months ago (2015-09-15 10:42:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339293002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339293002/1
5 years, 3 months ago (2015-09-15 10:42:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 11:51:43 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 11:52:03 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/8c8c7523c2a6188d552ba35a7948285de0d40705
Cr-Commit-Position: refs/heads/master@{#30743}

Powered by Google App Engine
This is Rietveld 408576698