Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 133923002: Use a Finch Experiment to control the Browser Blacklist (Closed)

Created:
6 years, 11 months ago by csharp
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org, robertshield, sky, Alexei Svitkine (slow)
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Use a Finch Experiment to control the Browser Blacklist Also increase the states stored in the register to prevent the setup code from running multiple times per version if it fails to start one time. Also, this uses RegQueryValueEx and RegSetValueEx instead of RegSetKeyValue and RegGetValue since they aren't available on XP. TBR=sky@chromium.org BUG=329023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244517

Patch Set 1 #

Patch Set 2 : Use reg function for XP #

Patch Set 3 : Fix other registry function #

Patch Set 4 : Fix unittests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+399 lines, -34 lines) Patch
M chrome/browser/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_win.cc View 2 chunks +3 lines, -0 lines 0 comments Download
A chrome/browser/chrome_elf_init_unittest_win.cc View 1 chunk +111 lines, -0 lines 0 comments Download
A chrome/browser/chrome_elf_init_win.h View 1 chunk +15 lines, -0 lines 0 comments Download
A chrome/browser/chrome_elf_init_win.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/blacklist.gypi View 2 chunks +5 lines, -1 line 0 comments Download
M chrome_elf/blacklist/blacklist.h View 1 chunk +24 lines, -8 lines 0 comments Download
M chrome_elf/blacklist/blacklist.cc View 1 2 4 chunks +82 lines, -13 lines 0 comments Download
M chrome_elf/blacklist/test/blacklist_test.cc View 1 2 3 3 chunks +34 lines, -11 lines 0 comments Download
M chrome_elf/chrome_elf.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome_elf/chrome_elf_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
csharp
Patch 1 is just https://codereview.chromium.org/120963002/. Patch 2 replaces the functions that aren't available on XP.
6 years, 11 months ago (2014-01-10 16:14:14 UTC) #1
csharp
I'd forgotten to fix the unit tests, they should now be fixed (testing now).
6 years, 11 months ago (2014-01-10 21:36:06 UTC) #2
Cait (Slow)
Regkey handling changes lgtm
6 years, 11 months ago (2014-01-10 21:54:07 UTC) #3
Cait (Slow)
Regkey handling changes lgtm
6 years, 11 months ago (2014-01-10 21:54:10 UTC) #4
robertshield
lgtm
6 years, 11 months ago (2014-01-11 01:40:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/csharp@chromium.org/133923002/200002
6 years, 11 months ago (2014-01-13 13:54:28 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-13 16:57:07 UTC) #7
Message was sent while issue was closed.
Change committed as 244517

Powered by Google App Engine
This is Rietveld 408576698