Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1339213004: On gpu, use max(r,g,b) for coverage alpha in LCD and update lcd blend gm. (Closed)

Created:
5 years, 3 months ago by egdaniel
Modified:
5 years, 3 months ago
Reviewers:
jvanverth1, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

On gpu, use max(r,g,b) for coverage alpha in LCD and update lcd blend gm. BUG=skia: Committed: https://skia.googlesource.com/skia/+/27b6335c71bccb96206ff0495793433bfa982777

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -14 lines) Patch
M gm/lcdblendmodes.cpp View 3 chunks +35 lines, -10 lines 2 comments Download
M src/gpu/GrTextContext.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/effects/GrBitmapTextGeoProc.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M src/gpu/effects/GrDistanceFieldGeoProc.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (2 generated)
egdaniel
5 years, 3 months ago (2015-09-15 18:57:29 UTC) #2
bsalomon
https://codereview.chromium.org/1339213004/diff/1/gm/lcdblendmodes.cpp File gm/lcdblendmodes.cpp (right): https://codereview.chromium.org/1339213004/diff/1/gm/lcdblendmodes.cpp#newcode47 gm/lcdblendmodes.cpp:47: return SkString("lcdblendmodes"); why this change?
5 years, 3 months ago (2015-09-15 19:08:34 UTC) #3
egdaniel
https://codereview.chromium.org/1339213004/diff/1/gm/lcdblendmodes.cpp File gm/lcdblendmodes.cpp (right): https://codereview.chromium.org/1339213004/diff/1/gm/lcdblendmodes.cpp#newcode47 gm/lcdblendmodes.cpp:47: return SkString("lcdblendmodes"); On 2015/09/15 19:08:34, bsalomon wrote: > why ...
5 years, 3 months ago (2015-09-15 19:10:30 UTC) #4
jvanverth1
Changes to text shaders look good. As discussed, there are some issues with DF Text, ...
5 years, 3 months ago (2015-09-15 19:38:01 UTC) #5
bsalomon
lgtm
5 years, 3 months ago (2015-09-15 19:40:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339213004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339213004/1
5 years, 3 months ago (2015-09-15 20:08:05 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 20:13:53 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/27b6335c71bccb96206ff0495793433bfa982777

Powered by Google App Engine
This is Rietveld 408576698