Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 1339193002: Add flag to tlslite's HandshakeSettings to disable channel ID on the test server (Closed)

Created:
5 years, 3 months ago by nharper
Modified:
5 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flag to tlslite's HandshakeSettings to disable channel ID on the test server BUG=467312 Committed: https://crrev.com/d847891ff6043c03f71656fe735e65dcf8acc934 Cr-Commit-Position: refs/heads/master@{#348980}

Patch Set 1 #

Patch Set 2 : Use correct diffbase #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -2 lines) Patch
M third_party/tlslite/README.chromium View 1 1 chunk +2 lines, -0 lines 0 comments Download
A third_party/tlslite/patches/disable_channel_id.patch View 1 chunk +53 lines, -0 lines 1 comment Download
M third_party/tlslite/tlslite/handshakesettings.py View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/tlslite/tlslite/tlsconnection.py View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
nharper
Trybots are unhappy because it can't cleanly apply this patch without https://codereview.chromium.org/1336143002/. I have tests ...
5 years, 3 months ago (2015-09-14 22:41:05 UTC) #2
davidben
lgtm https://codereview.chromium.org/1339193002/diff/20001/third_party/tlslite/patches/disable_channel_id.patch File third_party/tlslite/patches/disable_channel_id.patch (right): https://codereview.chromium.org/1339193002/diff/20001/third_party/tlslite/patches/disable_channel_id.patch#newcode1 third_party/tlslite/patches/disable_channel_id.patch:1: diff --git a/third_party/tlslite/tlslite/handshakesettings.py b/third_party/tlslite/tlslite/handshakesettings.py [Did not review; assuming ...
5 years, 3 months ago (2015-09-15 15:51:06 UTC) #3
davidben
Clearly I should ask you to update to tlslite 0.4.9 and take over maintaining third_party/tlslite ...
5 years, 3 months ago (2015-09-15 15:53:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339193002/20001
5 years, 3 months ago (2015-09-15 20:15:41 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-15 20:38:28 UTC) #7
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d847891ff6043c03f71656fe735e65dcf8acc934 Cr-Commit-Position: refs/heads/master@{#348980}
5 years, 3 months ago (2015-09-15 20:39:17 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:49:05 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d847891ff6043c03f71656fe735e65dcf8acc934
Cr-Commit-Position: refs/heads/master@{#348980}

Powered by Google App Engine
This is Rietveld 408576698