Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1339183003: NOT FOR LANDING Experiment with allocating SVGImageForContainer on demand (Closed)

Created:
5 years, 3 months ago by davve
Modified:
5 years, 2 months ago
Reviewers:
CC:
blink-reviews, dshwang, eae+blinkwatch, fs, apavlov+blink_chromium.org, kinuko+watch, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, Yoav Weiss, krit, blink-reviews-css, szager+layoutwatch_chromium.org, dglazkov+blink, gavinp+loader_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, gyuyoung2, rwlbuis, blink-reviews-style_chromium.org, zoltan1, blink-reviews-layout_chromium.org, darktears, Nate Chapin, tyoshino+watch_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, slimming-paint-reviews_chromium.org, f(malita), Stephen Chennney
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

NOT FOR LANDING Experiment with allocating SVGImageForContainer on demand Delay creation of SVGImageForContainer until paint-time. If we want to support fragment URLs, the map from layout object to SVGImageForContainer inside ImageResource proved inadequate since one SVGImage could be used in one layout object several times with differing sizes (and fragment URLs, if we want to stick the fragment URL inside SVGImageForContainer). TODO: Only background images and <img> work. E.g. border-image and svg:image are broken. TODO: Only store the potential fragment inside SVGImageForContainer and delay resolving to a complete URL as long as possible. TODO: Memory management BUG=128055

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -213 lines) Patch
M LayoutTests/svg/zoom/page/zoom-svg-as-background-with-relative-size.html View 1 chunk +1 line, -5 lines 0 comments Download
M Source/core/css/CSSImageSetValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSImageValue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/fetch/ImageResource.h View 3 chunks +0 lines, -7 lines 0 comments Download
M Source/core/fetch/ImageResource.cpp View 6 chunks +0 lines, -69 lines 0 comments Download
M Source/core/layout/LayoutImage.h View 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/layout/LayoutImage.cpp View 3 chunks +0 lines, -24 lines 0 comments Download
M Source/core/layout/LayoutImageResource.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutImageResource.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/layout/LayoutImageResourceStyleImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/LayoutImageResourceStyleImage.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/layout/LayoutListMarker.cpp View 1 chunk +1 line, -8 lines 0 comments Download
M Source/core/layout/shapes/ShapeOutsideInfo.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/layout/svg/LayoutSVGImage.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/LayoutSVGImage.cpp View 1 3 chunks +0 lines, -26 lines 0 comments Download
M Source/core/paint/BackgroundImageGeometry.cpp View 1 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/paint/BoxPainter.cpp View 1 3 chunks +7 lines, -2 lines 0 comments Download
M Source/core/paint/ImagePainter.cpp View 1 3 chunks +16 lines, -0 lines 0 comments Download
M Source/core/paint/NinePieceImagePainter.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/style/StyleFetchedImage.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/style/StyleFetchedImage.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/style/StyleFetchedImageSet.h View 2 chunks +5 lines, -4 lines 0 comments Download
M Source/core/style/StyleFetchedImageSet.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M Source/core/style/StyleGeneratedImage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/style/StyleImage.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/style/StylePendingImage.h View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/svg/graphics/SVGImage.h View 1 2 chunks +3 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 6 chunks +18 lines, -10 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.h View 3 chunks +8 lines, -4 lines 0 comments Download
M Source/core/svg/graphics/SVGImageForContainer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698