Add localized default audio device names.

chrome/common/media/media_resource_provider.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/logging.h"
+#include "chrome/common/media/media_resource_provider.h"
+#include "chrome/grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace chrome_common_media {
+
+int MediaMessageIdToGrdId(media::MessageId message_id) {
+  switch (message_id) {
+    case media::DEFAULT_AUDIO_DEVICE_NAME:
+      return IDS_DEFAULT_AUDIO_DEVICE_NAME;
+#if defined(OS_WIN)
+    case media::COMMUNICATIONS_AUDIO_DEVICE_NAME:
+      return IDS_COMMUNICATIONS_AUDIO_DEVICE_NAME;
+#endif
+#if defined(OS_CHROMEOS)
+    case media::BEAMFORMING_ON_DEFAULT_AUDIO_INPUT_DEVICE_NAME:
+      return IDS_BEAMFORMING_ON_DEFAULT_AUDIO_INPUT_DEVICE_NAME;
+    case media::BEAMFORMING_OFF_DEFAULT_AUDIO_INPUT_DEVICE_NAME:
+      return IDS_BEAMFORMING_OFF_DEFAULT_AUDIO_INPUT_DEVICE_NAME;
+#endif
+    default:
+      NOTREACHED();
+      return 0;
+  }
+}
+
+base::string16 LocalizedStringProvider(media::MessageId message_id) {
+  return l10n_util::GetStringUTF16(MediaMessageIdToGrdId(message_id));

[jungshik at Google, 2015/09/17 21:56:43]

It's more a note to myself than a comment on this cl. For more complex messages,
to avoid adding more wrappers like this here (and net/), methods in l10n_util
had better be split into a method (getting a string from res bundle) and
formatting methods.

[ajm, 2015/09/17 22:42:04]

I'm probably misunderstanding, but I'm not sure of the relevance to this case.
This wrapper exists simply because we can't depend on chrome/ in media/. 

[jungshik at Google, 2015/09/18 22:33:48]

Sorry that I was not clear. Nothing wrong with the current change. 

In the future, if media/ or net/ require more than just a string with no
formatting (i.e. they require strings to be formatted with one or more
parameters), we need to separate 

// I simplified a function prototype (it's a bit longer than this).
// there are versions of this taking up to 4 args  
string GetStringF(int msgid, string arg1, string arg2); 

to two parts 

string GetString(int msgid); 
string GetStringFormatWithMsg(string msg, string arg1, string arg2); 

The former requires an access to the resource bundle and needs a wrapper, but
the latter does not. 

So with your wrapper (StringProvider), you get |msg| and pass it to the latter
to get a formatted result. For complex messages (plural, time, date, etc), what
corresponds to the latter is already available in  base/i18n/message_formatter.h
and you can use the above pattern (if/when there arises a need) without doing
any more change. 

[ajm, 2015/09/21 19:49:26]

Ah, I get it. Thanks.

+}
+
+}  // namespace chrome_common_media