Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339173002: Fix devtools documentation issue. (Closed)

Created:
5 years, 3 months ago by not at google - send to devlin
Modified:
5 years, 3 months ago
Reviewers:
mkearney1, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, Bons, yurys, nodir, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix devtools documentation issue. devToolsConnection.onDisconnect should be devToolsConnection.onDisconnect.addListener. BUG=526882 R=pfeldman@chromium.org NOTRY=true Committed: https://crrev.com/3fa5b0aec0c7361fa666e4145da0ea9167f55ecd Cr-Commit-Position: refs/heads/master@{#348751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/common/extensions/docs/templates/articles/devtools.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
not at google - send to devlin
5 years, 3 months ago (2015-09-14 22:28:13 UTC) #1
pfeldman
lgtm
5 years, 3 months ago (2015-09-14 22:43:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339173002/1
5 years, 3 months ago (2015-09-14 22:46:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 22:56:34 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3fa5b0aec0c7361fa666e4145da0ea9167f55ecd Cr-Commit-Position: refs/heads/master@{#348751}
5 years, 3 months ago (2015-09-14 22:57:19 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:28 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/3fa5b0aec0c7361fa666e4145da0ea9167f55ecd
Cr-Commit-Position: refs/heads/master@{#348751}

Powered by Google App Engine
This is Rietveld 408576698