Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1339143002: PPC: [builtins] Simplify String constructor code. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Simplify String constructor code. Port eadfd666318c1dd959d7fac7c27538ef478a8b72 Original commit message: The String constructor was somewhat complex with a lot of micro optimizations that are not relevant or even misguided. It would be really hard to port that code to ES6, which requires String to be subclassable. So as a first step we reduced the necessary complexity to the bare minimum (also removing the last user of the fairly complex MacroAssembler::LookupNumberStringCache method). This also removes the counters for the String constructor, which were not properly exposed anymore (and not kept in sync with inlined versions of the String constructor anyway). R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/4ca74e4f80259fa4c669f6921171dd9e2b013748 Cr-Commit-Position: refs/heads/master@{#30722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -190 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +63 lines, -109 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +0 lines, -72 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-14 18:54:52 UTC) #1
michael_dawson
On 2015/09/14 18:54:52, mtbrandyberry wrote: lgtm
5 years, 3 months ago (2015-09-14 19:00:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339143002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339143002/1
5 years, 3 months ago (2015-09-14 19:00:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:16:40 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 23:17:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4ca74e4f80259fa4c669f6921171dd9e2b013748
Cr-Commit-Position: refs/heads/master@{#30722}

Powered by Google App Engine
This is Rietveld 408576698