LayoutTests/webmidi/loopback-receive.html - Issue 1339123002: Remove some usage of testRunner.setPermission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/webmidi/loopback-receive.html

Issue 1339123002: Remove some usage of testRunner.setPermission. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@notifications-flakyness

Patch Set: review comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector/geolocation-emulation-tests-expected.txt ('k') | LayoutTests/webmidi/loopback-receive-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/webmidi/loopback-receive.html

diff --git a/LayoutTests/webmidi/loopback-receive.html b/LayoutTests/webmidi/loopback-receive.html

index 7cfc017e6135f3e0540445f4d3ab6b42fb99ac98..4a2b21c5289849deb19f11f4b4c9036ece4b5008 100644

--- a/LayoutTests/webmidi/loopback-receive.html

+++ b/LayoutTests/webmidi/loopback-receive.html

@@ -2,19 +2,17 @@

<html>

<head>

+<script src="../resources/permissions-helper.js"></script>

</head>

<body>

description("Test if midimessage event handler work.");

-shouldBeDefined("testRunner.setPermission");

shouldBeDefined("navigator.requestMIDIAccess");

window.jsTestIsAsync = true;

-testRunner.setPermission('midi-sysex', 'granted', location.origin, location.origin);

testData = [

// Complete messages.

[0x80, 0x00, 0x00],

@@ -73,7 +71,9 @@ function test(useAddEventListener) {

});

}

-test(false).then(test.bind(null, true)).then(finishJSTest, finishJSTest);

+PermissionsHelper.setPermission('midi-sysex', 'granted').then(function() {

+ test(false).then(test.bind(null, true)).then(finishJSTest, finishJSTest);

+});

</script>

</body>