Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339093002: Have SkVarAlloc::alloc() use sk_malloc_throw. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
Reviewers:
mtklein, Will Harris
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have SkVarAlloc::alloc() use sk_malloc_throw. Very right, it's not prepared to handle return-NULL mallocs at all. BUG=530759 Committed: https://skia.googlesource.com/skia/+/5a744b780190adbe6f210ffa4da9693b66d87afd

Patch Set 1 #

Patch Set 2 : no, always throw #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -11 lines) Patch
M src/core/SkRecord.h View 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkVarAlloc.h View 1 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkVarAlloc.cpp View 1 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/GrBatchFontCache.cpp View 1 chunk +1 line, -1 line 0 comments Download
M tests/VarAllocTest.cpp View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339093002/20001
5 years, 3 months ago (2015-09-14 13:56:27 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 14:02:03 UTC) #4
mtklein_C
5 years, 3 months ago (2015-09-14 14:02:35 UTC) #6
Will Harris
lgtm thanks for the fix!
5 years, 3 months ago (2015-09-14 17:22:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339093002/20001
5 years, 3 months ago (2015-09-14 18:08:57 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-14 18:08:58 UTC) #10
mtklein
lgtm
5 years, 3 months ago (2015-09-14 18:09:13 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 18:11:21 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5a744b780190adbe6f210ffa4da9693b66d87afd

Powered by Google App Engine
This is Rietveld 408576698