Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1339043002: Simplify SelfKeepAlive<T>'s representation. (Closed)

Created:
5 years, 3 months ago by sof
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, oilpan-reviews, kouhei+heap_chromium.org, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify SelfKeepAlive<T>'s representation. Following r202197, a Persistent<> is only instantiated when assigned a non-null pointer value. Consequently, SelfKeepAlive<>'s use of an OwnPtr<> indirection to achieve the same is no longer needed. R=haraken BUG=420515 Committed: https://crrev.com/7054092ea37895921e20bfd5ef4db9caff34a7f7 git-svn-id: svn://svn.chromium.org/blink/trunk@202202 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/platform/heap/Handle.h View 1 chunk +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
sof
please take a look.
5 years, 3 months ago (2015-09-14 12:28:50 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-14 13:52:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339043002/1
5 years, 3 months ago (2015-09-14 14:10:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202202
5 years, 3 months ago (2015-09-14 14:15:31 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:32:13 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7054092ea37895921e20bfd5ef4db9caff34a7f7

Powered by Google App Engine
This is Rietveld 408576698