Chromium Code Reviews| Index: content/renderer/media/media_stream_dependency_factory.cc |
| diff --git a/content/renderer/media/media_stream_dependency_factory.cc b/content/renderer/media/media_stream_dependency_factory.cc |
| index 8d4fe56bdd811ccc2d6f4a1c6a07fbb25044fdb0..20ad05752c042370e1021f71272d017b9ea30fef 100644 |
| --- a/content/renderer/media/media_stream_dependency_factory.cc |
| +++ b/content/renderer/media/media_stream_dependency_factory.cc |
| @@ -367,7 +367,7 @@ void MediaStreamDependencyFactory::CreateNativeMediaSources( |
| } |
| scoped_refptr<WebRtcAudioCapturer> capturer( |
| - MaybeCreateAudioCapturer(render_view_id, device_info)); |
| + CreateAudioCapturer(render_view_id, device_info)); |
| if (!capturer.get()) { |
| DLOG(WARNING) << "Failed to create the capturer for device " |
| << device_info.device.id; |
| @@ -462,14 +462,9 @@ MediaStreamDependencyFactory::CreateNativeAudioMediaStreamTrack( |
| } |
| } |
| - std::string track_id = base::UTF16ToUTF8(track.id()); |
| - scoped_refptr<WebRtcAudioCapturer> capturer; |
| - if (GetWebRtcAudioDevice()) |
| - capturer = GetWebRtcAudioDevice()->GetDefaultCapturer(); |
| - |
| scoped_refptr<webrtc::AudioTrackInterface> audio_track( |
| - CreateLocalAudioTrack(track_id, |
| - capturer, |
| + CreateLocalAudioTrack(base::UTF16ToUTF8(track.id()), |
|
perkj_chrome
2014/01/14 12:53:55
you can also do track.id().utf8() if you want.I am
no longer working on chromium
2014/01/14 14:10:56
Good to know. id().utf8() looks cleaner to me.
|
| + source_data->GetAudioCapturer(), |
| webaudio_source.get(), |
| source_data->local_audio_source(), |
| &track_constraints)); |
| @@ -930,43 +925,15 @@ void MediaStreamDependencyFactory::CleanupPeerConnectionFactory() { |
| } |
| scoped_refptr<WebRtcAudioCapturer> |
| -MediaStreamDependencyFactory::MaybeCreateAudioCapturer( |
| +MediaStreamDependencyFactory::CreateAudioCapturer( |
| int render_view_id, |
| const StreamDeviceInfo& device_info) { |
| // TODO(xians): Handle the cases when gUM is called without a proper render |
| // view, for example, by an extension. |
| DCHECK_GE(render_view_id, 0); |
| - scoped_refptr<WebRtcAudioCapturer> capturer = |
| - GetWebRtcAudioDevice()->GetDefaultCapturer(); |
| - |
| - // If the default capturer does not exist or |render_view_id| == -1, create |
| - // a new capturer. |
| - bool is_new_capturer = false; |
| - if (!capturer.get()) { |
| - capturer = WebRtcAudioCapturer::CreateCapturer(); |
| - is_new_capturer = true; |
| - } |
| - |
| - if (!capturer->Initialize( |
| - render_view_id, |
| - static_cast<media::ChannelLayout>( |
| - device_info.device.input.channel_layout), |
| - device_info.device.input.sample_rate, |
| - device_info.device.input.frames_per_buffer, |
| - device_info.session_id, |
| - device_info.device.id, |
| - device_info.device.matched_output.sample_rate, |
| - device_info.device.matched_output.frames_per_buffer, |
| - device_info.device.input.effects)) { |
| - return NULL; |
| - } |
| - |
| - // Add the capturer to the WebRtcAudioDeviceImpl if it is a new capturer. |
| - if (is_new_capturer) |
| - GetWebRtcAudioDevice()->AddAudioCapturer(capturer); |
| - |
| - return capturer; |
| + return WebRtcAudioCapturer::CreateCapturer(render_view_id, device_info, |
| + GetWebRtcAudioDevice()); |
| } |
| void MediaStreamDependencyFactory::AddNativeTrackToBlinkTrack( |