Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Side by Side Diff: content/renderer/media/webrtc_audio_capturer_unittest.cc

Issue 133903004: Cleaned up the WebRtcAudioCapturer a bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased and fixed the comment. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/logging.h" 5 #include "base/logging.h"
6 #include "content/renderer/media/webrtc_audio_capturer.h" 6 #include "content/renderer/media/webrtc_audio_capturer.h"
7 #include "content/renderer/media/webrtc_local_audio_track.h" 7 #include "content/renderer/media/webrtc_local_audio_track.h"
8 #include "media/audio/audio_parameters.h" 8 #include "media/audio/audio_parameters.h"
9 #include "media/base/audio_bus.h" 9 #include "media/base/audio_bus.h"
10 #include "testing/gmock/include/gmock/gmock.h" 10 #include "testing/gmock/include/gmock/gmock.h"
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 protected: 55 protected:
56 WebRtcAudioCapturerTest() 56 WebRtcAudioCapturerTest()
57 #if defined(OS_ANDROID) 57 #if defined(OS_ANDROID)
58 : params_(media::AudioParameters::AUDIO_PCM_LOW_LATENCY, 58 : params_(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
59 media::CHANNEL_LAYOUT_STEREO, 48000, 16, 960) { 59 media::CHANNEL_LAYOUT_STEREO, 48000, 16, 960) {
60 // Android works with a buffer size bigger than 20ms. 60 // Android works with a buffer size bigger than 20ms.
61 #else 61 #else
62 : params_(media::AudioParameters::AUDIO_PCM_LOW_LATENCY, 62 : params_(media::AudioParameters::AUDIO_PCM_LOW_LATENCY,
63 media::CHANNEL_LAYOUT_STEREO, 48000, 16, 128) { 63 media::CHANNEL_LAYOUT_STEREO, 48000, 16, 128) {
64 #endif 64 #endif
65 capturer_ = WebRtcAudioCapturer::CreateCapturer();
66 blink::WebMediaConstraints constraints; 65 blink::WebMediaConstraints constraints;
67 capturer_->Initialize(-1, params_.channel_layout(), params_.sample_rate(), 66 capturer_ = WebRtcAudioCapturer::CreateCapturer(
68 params_.frames_per_buffer(), 0, std::string(), 0, 0, 67 -1, StreamDeviceInfo(MEDIA_DEVICE_AUDIO_CAPTURE,
69 params_.effects(), constraints); 68 "", "", params_.sample_rate(),
69 params_.channel_layout(),
70 params_.frames_per_buffer()),
71 constraints,
72 NULL);
70 capturer_source_ = new MockCapturerSource(); 73 capturer_source_ = new MockCapturerSource();
71 EXPECT_CALL(*capturer_source_.get(), Initialize(_, capturer_.get(), 0)); 74 EXPECT_CALL(*capturer_source_.get(), Initialize(_, capturer_.get(), -1));
72 capturer_->SetCapturerSource(capturer_source_, 75 capturer_->SetCapturerSourceForTesting(capturer_source_, params_);
73 params_.channel_layout(),
74 params_.sample_rate(),
75 params_.effects(), constraints);
76 76
77 EXPECT_CALL(*capturer_source_.get(), SetAutomaticGainControl(true)); 77 EXPECT_CALL(*capturer_source_.get(), SetAutomaticGainControl(true));
78 EXPECT_CALL(*capturer_source_.get(), Start()); 78 EXPECT_CALL(*capturer_source_.get(), Start());
79 track_ = WebRtcLocalAudioTrack::Create(std::string(), capturer_, NULL, 79 track_ = WebRtcLocalAudioTrack::Create(std::string(), capturer_, NULL,
80 NULL); 80 NULL);
81 static_cast<WebRtcLocalAudioSourceProvider*>( 81 static_cast<WebRtcLocalAudioSourceProvider*>(
82 track_->audio_source_provider())->SetSinkParamsForTesting(params_); 82 track_->audio_source_provider())->SetSinkParamsForTesting(params_);
83 track_->Start(); 83 track_->Start();
84 EXPECT_TRUE(track_->enabled()); 84 EXPECT_TRUE(track_->enabled());
85 } 85 }
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
132 EXPECT_EQ(cached_delay.InMilliseconds(), delay_ms); 132 EXPECT_EQ(cached_delay.InMilliseconds(), delay_ms);
133 EXPECT_EQ(cached_volume, expected_volume_value); 133 EXPECT_EQ(cached_volume, expected_volume_value);
134 EXPECT_EQ(cached_key_pressed, key_pressed); 134 EXPECT_EQ(cached_key_pressed, key_pressed);
135 135
136 track_->RemoveSink(sink.get()); 136 track_->RemoveSink(sink.get());
137 EXPECT_CALL(*capturer_source_.get(), Stop()); 137 EXPECT_CALL(*capturer_source_.get(), Stop());
138 capturer_->Stop(); 138 capturer_->Stop();
139 } 139 }
140 140
141 } // namespace content 141 } // namespace content
OLDNEW
« no previous file with comments | « content/renderer/media/webrtc_audio_capturer.cc ('k') | content/renderer/media/webrtc_audio_device_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698