Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1339023002: Rethrow cross-site exceptions as security errors (Closed)

Created:
5 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 3 months ago
Reviewers:
epertoso, haraken
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Rethrow cross-site exceptions as security errors BUG=530301 R=epertoso@chromium.org,haraken@chromium.org Committed: https://crrev.com/051023a269e548c5da19246c7db6e9870dac2f69 git-svn-id: svn://svn.chromium.org/blink/trunk@202211 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Patch Set 2 : updates #

Total comments: 1

Patch Set 3 : git cl set_commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -2 lines) Patch
A LayoutTests/http/tests/security/xss-DENIED-cross-origin-stack-overflow.html View 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/xss-DENIED-cross-origin-stack-overflow-expected.txt View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.h View 1 2 chunks +21 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8DOMWrapper.cpp View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
jochen (gone - plz use gerrit)
5 years, 3 months ago (2015-09-14 09:28:59 UTC) #1
epertoso
lgtm
5 years, 3 months ago (2015-09-14 09:40:08 UTC) #2
haraken
LGTM https://codereview.chromium.org/1339023002/diff/20001/Source/bindings/core/v8/V8DOMWrapper.cpp File Source/bindings/core/v8/V8DOMWrapper.cpp (right): https://codereview.chromium.org/1339023002/diff/20001/Source/bindings/core/v8/V8DOMWrapper.cpp#newcode152 Source/bindings/core/v8/V8DOMWrapper.cpp:152: // FIXME: Currently, Location is the only object ...
5 years, 3 months ago (2015-09-14 11:56:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339023002/40001
5 years, 3 months ago (2015-09-14 14:19:45 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/133307)
5 years, 3 months ago (2015-09-14 15:15:44 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1339023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1339023002/40001
5 years, 3 months ago (2015-09-14 15:41:26 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://src.chromium.org/viewvc/blink?view=rev&revision=202211
5 years, 3 months ago (2015-09-14 18:02:41 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:34:11 UTC) #15
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/051023a269e548c5da19246c7db6e9870dac2f69

Powered by Google App Engine
This is Rietveld 408576698