Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issue 1338993008: Fix webaudio's grit dependencies. (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
rtoy, brettw, Raymond Toy
CC:
blink-reviews, brettw, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix webaudio's grit dependencies. We need to set a grit define to build webaudio correctly; prior to this patch, we were setting it for all targets, when it really only needs to be set for blink_resources. R=rtoy@chromium.org BUG= Committed: https://crrev.com/cffae026f2e9c1c85cdbb001625462b59fdcbebe git-svn-id: svn://svn.chromium.org/blink/trunk@202233 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M public/BUILD.gn View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Dirk Pranke
5 years, 3 months ago (2015-09-14 22:31:03 UTC) #1
Raymond Toy
lgtm.
5 years, 3 months ago (2015-09-14 22:41:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338993008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338993008/1
5 years, 3 months ago (2015-09-14 22:42:58 UTC) #5
brettw
lgtm
5 years, 3 months ago (2015-09-14 22:44:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202233
5 years, 3 months ago (2015-09-14 23:39:08 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cffae026f2e9c1c85cdbb001625462b59fdcbebe

Powered by Google App Engine
This is Rietveld 408576698