Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 1338953002: Introduce composed tree version of startOfWord() (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce composed tree version of startOfWord() This patch introduces composed tree version of |startOfWord()| by templatizing original |startOfWord()| to work both DOM tree position and composed tree position version for introducing composed tree version of |VisibleSelection| class. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; no behavior changes Committed: https://crrev.com/de9d06a43d8514338769e6e8d013eb03eb4e76f2 git-svn-id: svn://svn.chromium.org/blink/trunk@202182 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 : 2015-09-14T11:03:14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -4 lines) Patch
M Source/core/editing/VisibleUnits.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +15 lines, -4 lines 0 comments Download
M Source/core/editing/VisibleUnitsTest.cpp View 1 chunk +37 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-09-14 03:33:27 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-09-14 03:36:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338953002/1
5 years, 3 months ago (2015-09-14 03:53:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/133200)
5 years, 3 months ago (2015-09-14 04:45:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1338953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1338953002/1
5 years, 3 months ago (2015-09-14 05:42:48 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202182
5 years, 3 months ago (2015-09-14 06:05:02 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:30:00 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de9d06a43d8514338769e6e8d013eb03eb4e76f2

Powered by Google App Engine
This is Rietveld 408576698