components/autofill/core/browser/autofill_external_delegate.h - Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_external_delegate.h

Issue 133893004: Allow deleting autofill password suggestions on Shift+Delete (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: deletion is working Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/autofill/content/renderer/password_autofill_agent.cc ('K') | « components/autofill/core/browser/autofill_driver.h ('k') | components/autofill/core/browser/autofill_external_delegate.cc » ('j') | components/autofill/core/browser/autofill_manager.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_external_delegate.h

diff --git a/components/autofill/core/browser/autofill_external_delegate.h b/components/autofill/core/browser/autofill_external_delegate.h

index 6f3f4d7067648993ba127a9c15084549406157d4..b8e8caa28d73044563176395ec7d04b906abe7a4 100644

--- a/components/autofill/core/browser/autofill_external_delegate.h

+++ b/components/autofill/core/browser/autofill_external_delegate.h

@@ -77,6 +77,7 @@ class AutofillExternalDelegate

void OnShowPasswordSuggestions(const std::vector<base::string16>& suggestions,

const std::vector<base::string16>& realms,

const FormFieldData& field,

+ const PasswordForm& password_form,

const gfx::RectF& bounds);

// Set the data list value associated with the current field.

@@ -144,6 +145,8 @@ class AutofillExternalDelegate

// The current form and field selected by Autofill.

FormData autofill_query_form_;

FormFieldData autofill_query_field_;

+ // The current password selected by Autofill.

+ PasswordForm autofill_query_password_form_;

// The bounds of the form field that user is interacting with.

gfx::RectF element_bounds_;